[
https://issues.apache.org/jira/browse/CB-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472721#comment-13472721
]
Andrew Grieve commented on CB-1600:
-----------------------------------
Main concern about your pull request is that self.viewController should not be
cast to CDVViewController*. Any APIs to be made available to plugins should go
in CDVCommandDelegate.h.
I think the solution should be to use only your isKindOf check and add a
comment about this being the case on 4.3 (doesn't seem to repro on 5.0)
> [ios] crash in MobileSpec under 4.3 during file transfer
> --------------------------------------------------------
>
> Key: CB-1600
> URL: https://issues.apache.org/jira/browse/CB-1600
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Reporter: Patrick Mueller
> Assignee: Andrew Grieve
>
> I've run Mobile Spec under iOS 4.3 (Xcode 4.5.1 on Lion), and noticed a
> consistent trap.
> The problem occurs in
> [CDVFileTransfer.m:477|https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVFileTransfer.m#L477]
> in method {{- (void)connection:(NSURLConnection*)connection
> didReceiveResponse:(NSURLResponse*)response}}.
> As near as I can tell, from the debugger, the object coming in as the
> response is not actually an NSHTTPURLResponse, and that's where the crash is
> - when it asks for the statusCode. Cast that didn't work, but you don't find
> out till you try to access something that's not there.
> Other debugger info:
> response expectedContentLength == -1
> response URL == http://cordova-filetransfer.jitsu.com/robots.txt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
