> On Jan. 9, 2011, 4:34 a.m., Thorsten Zachmann wrote: > > If you convert a list like that is the file openable by OO and looks like > > in words?
Yes. Let's check screenshot 6 and 7. > On Jan. 9, 2011, 4:34 a.m., Thorsten Zachmann wrote: > > libs/kotext/styles/KoListLevelProperties.cpp, line 386 > > <http://git.reviewboard.kde.org/r/100306/diff/3/?file=6400#file6400line386> > > > > The check for style.isNull() is not needed. style.attributeNS will > > return the default value when the style isNull. > > Please make the styleName a const variable. Good point. I followed the approach to access the "bullet-char" attribute. Changed also that one. > On Jan. 9, 2011, 4:34 a.m., Thorsten Zachmann wrote: > > filters/words/msword-odf/texthandler.cpp, line 1496 > > <http://git.reviewboard.kde.org/r/100306/diff/3/?file=6399#file6399line1496> > > > > The variable styleName is not needed you can just write > > > > return m_mainStyles->insert(...) Agree. > On Jan. 9, 2011, 4:34 a.m., Thorsten Zachmann wrote: > > filters/words/msword-odf/texthandler.cpp, line 1469 > > <http://git.reviewboard.kde.org/r/100306/diff/3/?file=6399#file6399line1469> > > > > How about giving the property directly in the function call. Ok, but why do you prefer this approach. Mine uses one local variable of type QString and 4 constant strings. Your uses 9 constant strings. Isn't memory allocated for each constant string? - Matus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100306/#review790 ----------------------------------------------------------- On Jan. 8, 2011, 8:13 p.m., Matus Uzak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100306/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2011, 8:13 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > Filter changes: > * Let's use the style-name attribute of a list-level-style-* to point to a > text style, which should be used to format the bullet/number of a list. > * The style is stored into office:styles to be accessible via the style > manager during layout. > > KoListLevelProperties changes: > * Lookup the referred style using the style manager and update the > CharacterStyleId of the KoListStyle. > > TODO: > * If this approach is correct, also other filters should be updated. > * Bullet sizes! > > > Diffs > ----- > > filters/words/msword-odf/texthandler.h 1465e66 > filters/words/msword-odf/texthandler.cpp b7d582c > libs/kotext/styles/KoListLevelProperties.cpp ec5a472 > > Diff: http://git.reviewboard.kde.org/r/100306/diff > > > Testing > ------- > > Using words application only, msword test documents containing numbered lists. > > > Screenshots > ----------- > > msword 2007 > http://git.reviewboard.kde.org/r/100306/s/33/ > words > http://git.reviewboard.kde.org/r/100306/s/34/ > words patched > http://git.reviewboard.kde.org/r/100306/s/35/ > msword (list item sizes) > http://git.reviewboard.kde.org/r/100306/s/36/ > words (list item sizes) > http://git.reviewboard.kde.org/r/100306/s/37/ > OO displaying current mswordodf filter output > http://git.reviewboard.kde.org/r/100306/s/40/ > OO (patched mswordodf filter output) > http://git.reviewboard.kde.org/r/100306/s/41/ > > > Thanks, > > Matus > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
