----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101644/#review3950 -----------------------------------------------------------
Ship it! Looks good. If you have commit access please commit or otherwise let me know and I can commit it for you. - Thorsten On June 16, 2011, 5:59 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101644/ > ----------------------------------------------------------- > > (Updated June 16, 2011, 5:59 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > The paCanvas and canvasItem are referenced without checking if they are not > NULL. > If they can not be null, then I'll change the patch to remove the not NULL > checking. > > > Diffs > ----- > > active/src/CanvasController.cpp ee7b90a > > Diff: http://git.reviewboard.kde.org/r/101644/diff > > > Testing > ------- > > I have not seen anything strange after the patch. > > > Thanks, > > Jaime Torres > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel