----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102107/#review5169 -----------------------------------------------------------
This review has been submitted with commit a624f6349358a01275e0cb07d3b46bf107359f89 by Sebastian Sauer to branch master. - Commit On July 28, 2011, 11:32 a.m., Sebastian Sauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102107/ > ----------------------------------------------------------- > > (Updated July 28, 2011, 11:32 a.m.) > > > Review request for Calligra and Casper Boemann. > > > Summary > ------- > > The problem is that if a table-cell does not define a table-border then we > are still drawing such a table border as visual helper for the user. Those > visual helper borders can be clipped off in some cases (I was so far only > able to reproduce the problem with one document at zoom-level 63%) cause we > don't take the width of that visual helper border into account on clipping. > > The attached patch solves that the easy way by just adjusting the painters > clipping in the textshape to be sure we don't cutoff cosmetic pens which are > exactly at the border of the shape ( x-pos=0, y-pos=0, > width=outlineRect().width(), height=outlineRect.height() ) and are therefore > partly (as in 1/2 of them) are drawn outside of the outlineRect. Since the > cosmetic pen has always a size of 1 pixel butting the half of could mean that > the pixel isn't drawn any longer (not sure there why it only happens with > some zoom-levels while it works fine with others). > > Now the question is if there is a better way to prevent to have that pixel > cutoff. Maybe even down the road somewhere in the textlayout-library? > > > Diffs > ----- > > plugins/textshape/TextShape.cpp 6fddca0 > > Diff: http://git.reviewboard.kde.org/r/102107/diff > > > Testing > ------- > > > Thanks, > > Sebastian > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
