----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105212/#review14601 -----------------------------------------------------------
What I'm not getting is how we would come into a case of saving paragraph style, but having graphicproperties as the place where we save. Can you enlighten me a bit. And why is it not a general problem then that child elements can be created somewhere else besides the element they are created within libs/odf/KoGenStyle.cpp <http://git.reviewboard.kde.org/r/105212/#comment11544> uhm we use i here but you have just change the initialization of it - C. Boemann On June 11, 2012, 6:49 a.m., Thorsten Zachmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105212/ > ----------------------------------------------------------- > > (Updated June 11, 2012, 6:49 a.m.) > > > Review request for Calligra. > > > Description > ------- > > When saving style child elements the child elements where always saved into > the default property. However this is not correct as the output of Jos tests > shows > > [01:53:45]: kofficetests-odp (17s) > [01:53:45]: [kofficetests-odp] odf/odp/114096.odp > [01:53:45]: [odf/odp/114096.odp] INVALIDSTYLESXML: (unknown file):267: error: > element "style:tab-stops" not allowed here; expected the element end-tag or > element "style:background-image", "style:columns" or "text:list-style" > MISSINGFILE: Object 1 INVALIDCONTENTXML: (unknown file):1061: error: element > "style:tab-stops" not allowed here; expected the element end-tag or element > "style:background-image", "style:columns" or "text:list-style" (unknown > file):1081: error: element "style:tab-stops" not allowed here; expected the > element end-tag or element "style:background-image", "style:columns" or > "text:list-style" > > The problem is that the stye:tab-stops are added to the graphic properties > but should be added to the paragraph properties. > > This patch adds the possibility to define the property the child elements > should be added too. > > > Diffs > ----- > > libs/kotext/styles/KoParagraphStyle.cpp dc02de3 > libs/odf/KoGenStyle.h 346504d > libs/odf/KoGenStyle.cpp 2fef9b3 > libs/odf/tests/TestKoGenStyles.cpp 062f3c9 > > Diff: http://git.reviewboard.kde.org/r/105212/diff/ > > > Testing > ------- > > Tested with the above document from calligratests and it works fine with it. > > > Thanks, > > Thorsten Zachmann > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
