> On June 6, 2012, 8:11 p.m., Jarosław Staniek wrote: > > kexi/plugins/reports/kexireportview.cpp, line 274 > > <http://git.reviewboard.kde.org/r/105164/diff/1/?file=66483#file66483line274> > > > > If we're on that: maybe verbs are better? > > If so: CSS -> Use CSS; Table -> Use Table > > > > > > Friedrich W. H. Kossebau wrote: > Yes, agree that could be improved as well, so picked up your proposal. > Also modified the message slightly (give CSS reference, make relative clauses > non-defining). > No idea about title, just that old "Styles" is not perfect. > > Adam Pigg wrote: > How about 'Export Format' or 'Export Style' ?
Tried that, but then I found out that to me again 'Export Report as Web Page', like the window title in the file selector, makes it more obvious that this dialog is still part of the same process. (And in a perfect world this dialog and the file selector one would be just subdialogs in an export wizard, but that improvement should not be part of this patch I think). Would you agree to this reasoning? Besides that I do not have a strong opinion, whatever you like more as title is fine with me. - Friedrich W. H. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105164/#review14454 ----------------------------------------------------------- On June 7, 2012, 12:13 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105164/ > ----------------------------------------------------------- > > (Updated June 7, 2012, 12:13 a.m.) > > > Review request for Calligra and Adam Pigg. > > > Description > ------- > > See summary. In detail the patch does: > * use "Export" instead of "Save" everywhere > * give hint to used file formats in tooltip/whatsthis > * use same phrases with all formats > > Like that solution? > > I was also tempted to turn the export buttons into a dropdown menu, to make > the toolbar less cluttered. No idea if that would clash with any Kexi UI > guidelines... > > > Diffs > ----- > > kexi/doc/dev/CHANGELOG-Kexi-js f4c055c > kexi/plugins/reports/kexireportview.h d119a86 > kexi/plugins/reports/kexireportview.cpp 0482984 > > Diff: http://git.reviewboard.kde.org/r/105164/diff/ > > > Testing > ------- > > Exported to all three formats, incl. overwriting files or not. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
