> On June 18, 2012, 6:41 a.m., Thorsten Zachmann wrote:
> > Some questions I have about the implementation:
> >
> > - What is the need of the class KPrAnimationsDataModel? would it not be
> > enought to use a pointer to the item in the KPrAnimationsTreeModel?
> >
> > - In the KPrAnimationsTreeModel you copy the data which is in the animation
> > steps into a new format. Do you think it would be possiblt to just use the
> > animationSteps as they are as when it gets copied both structures need to
> > be kept in sync which might turn out to be problematic
> >
> > About the timeline. I agree with your proposal that the lower part should
> > not be there by default but should popup when a animation is e.g. doubled
> > clicked to edit it. It could then also contain the widget to modify the
> > selected animation. With that there will be more space.
> >
> > I found a crash. To reproduce:
> > - Open a presentation with shape animations
> > - Select the animation tool
> > - Select a shape with an animation
> > - Select the default tool
> > - Delete the currently selected shape.
> > - Select the animation tool
> > -> this results in a crash
- Do you mean to use the same model for the two views. I was thinking in that,
but I want to implement some edition features in the views (like drag and drop)
and seems difficult to reuse the same things due to the basic view is a tree
view and the Time Line View is a custom table View. However after start with
the implementation of drag and drop I could have a better idea if I could merge
the data models. At the moment they share the same substructure of data (The
KPrCustomAnimationItem linked list), so there is not much duplication.
- I am going to think about that. At the moment KPrCustomAnimationItems keep
pointers to KPrShapeAnimations, but I would need to update the Step, substep
structure. Just to clarify, animations steps - substeps -KPrShapeAnimations
relation, works like:
Step
|--> SubStep -> KPrShapeAnimation "On click Animation"
|--> SubStep -> KPrShapeAnimation "After Previous Animation"
|-> KPrShapeAnimation "With previous animation"
If things work like that It seems easy to replace the current linked list with
the linked list of Steps - substeps. However I would like to have and
intermediate object to use when loading predefined animations from the XML
file. At the moment I think in two solutions: keep KPrCustomAnimationItem or
just extend KPrShapeAnimation to hold temporal animations (animations without
target). I have to think more about that.
- I think I fixed that yesterday. I can't reproduce the exact crash, but I
found a bug that could be related, so I am going to work on that.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105213/#review14819
-----------------------------------------------------------
On June 18, 2012, 12:53 a.m., Paul Mendez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105213/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 12:53 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Add a docker to the Animation Tool to display information of shape
> animations. The docker has the following features:
> - use a compound view with a time line for start, duration and animation type
> information.
> - Has a button to play shape animations live preview.
> - Layout edition buttons (edition features are not yet implemented)
>
> Add a model to manage animations data information
> Extend shapeAnimation class in order to save presentation-preset tags with
> information of animation type (entrance, exit, etc) and name.
>
> The patch is only for a GSoC progress Review. Though being usable (and I hope
> stable), not yet finished.
>
>
> Diffs
> -----
>
> stage/part/CMakeLists.txt 8617020a5e54ca640ef713257b94b4a8c9acf5fd
> stage/part/KPrAnimationsDataModel.h PRE-CREATION
> stage/part/KPrAnimationsDataModel.cpp PRE-CREATION
> stage/part/KPrAnimationsTimeLineView.h PRE-CREATION
> stage/part/KPrAnimationsTimeLineView.cpp PRE-CREATION
> stage/part/KPrAnimationsTreeModel.h PRE-CREATION
> stage/part/KPrAnimationsTreeModel.cpp PRE-CREATION
> stage/part/KPrCustomAnimationItem.h PRE-CREATION
> stage/part/KPrCustomAnimationItem.cpp PRE-CREATION
> stage/part/KPrTimeLineHeader.h PRE-CREATION
> stage/part/KPrTimeLineHeader.cpp PRE-CREATION
> stage/part/KPrTimeLineView.h PRE-CREATION
> stage/part/KPrTimeLineView.cpp PRE-CREATION
> stage/part/KPrViewModePreviewShapeAnimations.h PRE-CREATION
> stage/part/KPrViewModePreviewShapeAnimations.cpp PRE-CREATION
> stage/part/animations/KPrAnimationBase.h
> b12bfab8d71a9a9a6dc0695d2ed95bc2e7326352
> stage/part/animations/KPrAnimationBase.cpp
> 62bb2a2911c37962ab55a38ed0b753f7b390ce31
> stage/part/animations/KPrAnimationLoader.cpp
> b0680b401c86f743c15f4b9e6edea9c0de938eee
> stage/part/animations/KPrAnimationStep.h
> 26a9fcec4b1d894ffe4d7d1dd2458a34c35e3d64
> stage/part/animations/KPrShapeAnimation.h
> f5d9ac3b796e75f16970f80245e1fbb6673fe1b9
> stage/part/animations/KPrShapeAnimation.cpp
> 988cd14098d8ac1f9290b858540215d75d97f9f3
> stage/part/tools/animationtool/CMakeLists.txt
> 5f5cb93f681ab95b0294de540e681d44ea9d27cb
> stage/part/tools/animationtool/KPrAnimationTool.h
> dbf12b9226f4da7b975d49ee19e5c7568cef7367
> stage/part/tools/animationtool/KPrAnimationTool.cpp
> 99f3d5428f9a761d5376af6a5c1cf9a512266347
> stage/part/tools/animationtool/KPrShapeAnimationDocker.h PRE-CREATION
> stage/part/tools/animationtool/KPrShapeAnimationDocker.cpp PRE-CREATION
> stage/pics/hi32-action-after_previous.png PRE-CREATION
> stage/pics/hi32-action-edit_animation.png PRE-CREATION
> stage/pics/hi32-action-onclick.png PRE-CREATION
> stage/pics/hi32-action-unrecognized_animation.png PRE-CREATION
> stage/pics/hi32-action-with_previous.png PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/105213/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Mendez
>
>
_______________________________________________
calligra-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/calligra-devel
