> On Nov. 7, 2012, 2:27 p.m., Boudewijn Rempt wrote: > > active/main.cpp, line 53 > > <http://git.reviewboard.kde.org/r/107244/diff/1/?file=94020#file94020line53> > > > > Doesn't this change break opening a file from an argument? Also -- why > > create the MainWindow on the heap now?
It didn't broke opening a file arg. It worked. - Sujith ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/#review21555 ----------------------------------------------------------- On Nov. 7, 2012, 2:20 p.m., Sujith Haridasan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107244/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2012, 2:20 p.m.) > > > Review request for Calligra and Shantanu Tushar. > > > Description > ------- > > Moving calligra from QApplication to KApplication. Made changes to main.cpp > file. The reference was taken from plasma-mobile/shell. > > > Diffs > ----- > > active/main.cpp 81a00c6 > > Diff: http://git.reviewboard.kde.org/r/107244/diff/ > > > Testing > ------- > > Did some basic testing with presentation slide, Spread sheet and Word file. > Also tried to navigate and search strings. It worked fine. > > > Thanks, > > Sujith Haridasan > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel