----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107068/ -----------------------------------------------------------
(Updated Nov. 7, 2012, 8:59 p.m.) Review request for Calligra, Adam Pigg, Dimitrios Tanis, Radosław Wicik, and Oleg Kukharchuk. Changes ------- As proposed by Dimitrios: - display different the warning - while user is editing, hide the warning if overflow is fixed - upon saving, trim if needed Also: - the warning now informs how many characters would be trimmed (so is updated on every editing action) - refactored code displaying warning messages to avoid duplicates Description ------- Tables/Forms: show indication that edited or pasted text is trimmed. See also http://forum.kde.org/viewtopic.php?f=221&t=102475 thread. Screencasts with the feature: http://www.youtube.com/watch?v=Qdd7CaBonq0 http://www.youtube.com/watch?v=wjyGsWxnAEs This addresses bug 301136. http://bugs.kde.org/show_bug.cgi?id=301136 Diffs (updated) ----- kexi/core/kexidataiteminterface.h 639e875 kexi/core/kexidataiteminterface.cpp 8eb9d4d kexi/plugins/forms/kexiformscrollview.h 43ce3f9 kexi/plugins/forms/kexiformscrollview.cpp 9ba0fc4 kexi/plugins/forms/widgets/kexidblineedit.h faf954b kexi/plugins/forms/widgets/kexidblineedit.cpp f023937 kexi/widget/dataviewcommon/kexidataawareobjectiface.h ef5a892 kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp ba5266c kexi/widget/tableview/kexiinputtableedit.h fe20fb1 kexi/widget/tableview/kexiinputtableedit.cpp 8c62a28 kexi/widget/tableview/kexitableview.h e01ba05 kexi/widget/tableview/kexitableview.cpp a0e17c6 kexi/widget/tableview/kexitextformatter.h 880a36c kexi/widget/tableview/kexitextformatter.cpp c119056 Diff: http://git.reviewboard.kde.org/r/107068/diff/ Testing ------- Properly displays warnings and trims data Thanks, Jarosław Staniek
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel