----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108131/#review24608 -----------------------------------------------------------
This review has been submitted with commit a7c2ae265188c04e5406c917d8573646dd6a4e17 by Friedrich W. H. Kossebau to branch master. - Commit Hook On Jan. 3, 2013, 6:59 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108131/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2013, 6:59 p.m.) > > > Review request for Calligra, Pierre Stirnweiss and C. Boemann. > > > Description > ------- > > Looked all day at those lines, until I had the need to do something about it > :) > > Okay? > > For the visitor nethods I was not sure if the object to visit should be > passed as ref or const ref, as the methods did not really say if they are > supposed to be for read-only or modifying visits. So chose ref, to not > restrict. > > > Diffs > ----- > > libs/kotext/KoTextEditor.h e9e5234 > libs/kotext/KoTextEditor.cpp 18a1972 > libs/kotext/KoTextEditor_format.cpp 7bd345b > libs/kotext/KoTextEditor_p.h 823e888 > libs/kotext/KoTextEditor_undo.cpp 73600d6 > libs/kotext/changetracker/KoChangeTracker.h 65ed91f > libs/kotext/changetracker/KoChangeTracker.cpp dda52c7 > libs/kotext/commands/DeleteCommand.cpp 622062a > > Diff: http://git.reviewboard.kde.org/r/108131/diff/ > > > Testing > ------- > > "make test" results as before. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
