----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108326/#review25168 -----------------------------------------------------------
i like it but will not approve just yet - C. Boemann On Jan. 10, 2013, 3:50 p.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108326/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2013, 3:50 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This patch updates the MinVersion and PluginVersion of all Calligra plugins > (except for Sheets function plugins and Kexi plugins) to 27 (to reflect that > current master will become 2.7). It changes the loading of plugins from <= > MinVersion to == PluginVersion since we cannot reliably load any plugin that > wasn't built against the current version. > > The pigment plugins now no longer have an X-Flake-PluginVerson property, but > X-Pigment-PLuginVersion. > > I did some testing, but this patch needs careful considering since any error > means that a plugin won't get loaded. > > > Diffs > ----- > > active/calligraactive.desktop 444dffe > braindump/plugins/quickstates/braindumpquickstates.desktop dec7df8 > braindump/plugins/stateshape/stateshape.desktop cac621e > braindump/plugins/webshape/webshape.desktop 9141cd1 > braindump/src/View.cpp 4247649 > flow/plugins/dockers/flowdockersplugin.desktop 463bfb0 > karbon/plugins/dockers/karbondockersplugin.desktop e203c65 > karbon/plugins/filtereffects/karbonfiltereffects.desktop b12f1e3 > karbon/plugins/tools/karbontools.desktop 44ad7dd > kexi/plugins/shapes/relationdesign/kexirelationdesignshape.desktop 64dfd2c > krita/data/templates/comics/BD-EuroTemplate.desktop 4737fc3 > krita/data/templates/comics/Comics-USTemplate.desktop 9412894 > krita/data/templates/comics/Manga-JpTemplate.desktop a69be2a > krita/data/templates/comics/a4_waffle_grid.desktop 427efa5 > krita/image/brushengine/kis_paintop_registry.cc 63b971c > krita/image/filter/kis_filter_registry.cc 85ad15b > krita/image/generator/kis_generator_registry.cpp f4faa28 > krita/krita.desktop 90ef6e4 > krita/kritapart.desktop c58f58f > krita/plugins/assistants/RulerAssistant/kritarulerassistanttool.desktop > 7a911f6 > > krita/plugins/colorspaces/extensions/krita_colorspaces_extensions_plugin.desktop > 1e0ebc9 > krita/plugins/extensions/bigbrother/kritabigbrother.desktop f9aca4c > krita/plugins/extensions/colorrange/kritacolorrange.desktop 747f819 > > krita/plugins/extensions/colorspaceconversion/kritacolorspaceconversion.desktop > 642c1a8 > krita/plugins/extensions/compose/kritalayercompose.desktop c137c78 > > krita/plugins/extensions/dockers/advancedcolorselector/krita_colorselectorng.desktop > 80433bb > > krita/plugins/extensions/dockers/artisticcolorselector/krita_artisticcolorselector.desktop > 471c747 > krita/plugins/extensions/dockers/channeldocker/krita_channeldocker.desktop > 939b430 > > krita/plugins/extensions/dockers/compositiondocker/krita_compositiondocker.desktop > d7dd014 > krita/plugins/extensions/dockers/defaultdockers/kritadefaultdockers.desktop > 1367cac > krita/plugins/extensions/dockers/digitalmixer/krita_digitalmixer.desktop > b5ae83b > > krita/plugins/extensions/dockers/dockerplugintemplate/krita_presetdocker.desktop > 9ba17ee > krita/plugins/extensions/dockers/flipbook/krita_flipbookdocker.desktop > 342abef > krita/plugins/extensions/dockers/historydocker/kritahistorydocker.desktop > 90c1f45 > krita/plugins/extensions/dockers/imagedocker/kritaimagedocker.desktop > fc89643 > krita/plugins/extensions/dockers/lut/krita_lutdocker.desktop f89736a > krita/plugins/extensions/dockers/patterndocker/krita_patterndocker.desktop > 881e3ed > krita/plugins/extensions/dockers/presetdocker/krita_presetdocker.desktop > 9ba17ee > > krita/plugins/extensions/dockers/smallcolorselector/krita_smallcolorselector.desktop > 300e1fa > > krita/plugins/extensions/dockers/specificcolorselector/krita_specificcolorselector.desktop > 70f2be2 > krita/plugins/extensions/dockers/tasksetdocker/krita_tasksetdocker.desktop > e6b7866 > krita/plugins/extensions/dropshadow/kritadropshadow.desktop b58633a > krita/plugins/extensions/histogram/kritahistogram.desktop 4f54481 > krita/plugins/extensions/imagesize/kritaimagesize.desktop 9cc9a55 > krita/plugins/extensions/imagesplit/kritaimagesplit.desktop 33b3d56 > krita/plugins/extensions/metadataeditor/kritametadataeditor.desktop df35d24 > krita/plugins/extensions/modify_selection/kritamodifyselection.desktop > 36c6ddf > krita/plugins/extensions/rotateimage/kritarotateimage.desktop fd5d8fb > krita/plugins/extensions/separate_channels/kritaseparatechannels.desktop > 5c70b6d > krita/plugins/extensions/shearimage/kritashearimage.desktop 8053eed > krita/plugins/extensions/shiva/kritashivafilters.desktop 114f154 > krita/plugins/extensions/shiva/kritashivagenerators.desktop 84a6e14 > krita/plugins/filters/blur/kritablurfilter.desktop 027ab2a > krita/plugins/filters/colors/kritaextensioncolorsfilters.desktop ff8c134 > krita/plugins/filters/colorsfilters/kritacolorsfilter.desktop 441ea40 > krita/plugins/filters/convolutionfilters/kritaconvolutionfilters.desktop > 5f6b910 > krita/plugins/filters/dodgeburn/kritadodgeburn.desktop 7e0990c > krita/plugins/filters/embossfilter/kritaembossfilter.desktop 3ad3b28 > krita/plugins/filters/example/kritaexample.desktop 1110cce > krita/plugins/filters/fastcolortransfer/kritafastcolortransfer.desktop > a05598b > krita/plugins/filters/imageenhancement/kritaimageenhancement.desktop > cff3555 > krita/plugins/filters/levelfilter/kritalevelfilter.desktop b7ce6b3 > krita/plugins/filters/noisefilter/kritanoisefilter.desktop f456c56 > krita/plugins/filters/oilpaintfilter/kritaoilpaintfilter.desktop 370c200 > krita/plugins/filters/phongbumpmap/kritaphongbumpmapfilter.desktop 0e054b1 > krita/plugins/filters/pixelizefilter/kritapixelizefilter.desktop f3ef12e > krita/plugins/filters/raindropsfilter/kritaraindropsfilter.desktop 1c481f5 > krita/plugins/filters/randompickfilter/kritarandompickfilter.desktop > e52aba9 > krita/plugins/filters/roundcorners/kritaroundcornersfilter.desktop 02f84b5 > krita/plugins/filters/smalltilesfilter/kritasmalltilesfilter.desktop > f131a97 > krita/plugins/filters/sobelfilter/kritasobelfilter.desktop b8f068f > krita/plugins/filters/unsharp/kritaunsharpfilter.desktop 790778d > krita/plugins/filters/wavefilter/kritawavefilter.desktop 4fb613e > krita/plugins/generators/solid/kritacolorgenerator.desktop 8ca1809 > krita/plugins/paintops/chalk/kritachalkpaintop.desktop a828e36 > krita/plugins/paintops/colorsmudge/kritacolorsmudgepaintop.desktop c308a13 > krita/plugins/paintops/curvebrush/kritacurvepaintop.desktop 57d82eb > krita/plugins/paintops/defaultpaintops/kritadefaultpaintops.desktop 4963f6a > krita/plugins/paintops/deform/kritadeformpaintop.desktop 287dfb0 > krita/plugins/paintops/dynadraw/kritadynapaintop.desktop dfa994e > krita/plugins/paintops/experiment/kritaexperimentpaintop.desktop 911f5b5 > krita/plugins/paintops/filterop/kritafilterop.desktop 6fb4387 > krita/plugins/paintops/gridbrush/kritagridpaintop.desktop 77591af > krita/plugins/paintops/hairy/kritahairypaintop.desktop 7e62394 > krita/plugins/paintops/hatching/kritahatchingpaintop.desktop 48b85c1 > krita/plugins/paintops/libbrush/kis_brush_registry.cpp c063140 > krita/plugins/paintops/mypaint/kritamypaintpaintop.desktop 7f7dc09 > krita/plugins/paintops/particle/kritaparticlepaintop.desktop e02ee70 > krita/plugins/paintops/sketch/kritasketchpaintop.desktop 445efb8 > krita/plugins/paintops/spray/kritaspraypaintop.desktop d1a7a7a > krita/plugins/tools/defaulttools/kritadefaulttools.desktop 858065d > krita/plugins/tools/selectiontools/kritaselectiontools.desktop b83a9a3 > krita/plugins/tools/tool_crop/kritatoolcrop.desktop 0d3bb2c > krita/plugins/tools/tool_dyna/kritatooldyna.desktop 26c701b > krita/plugins/tools/tool_grid/kritatoolgrid.desktop 3acd999 > krita/plugins/tools/tool_perspectivegrid/kritatoolperspectivegrid.desktop > 2f2a047 > krita/plugins/tools/tool_polygon/kritatoolpolygon.desktop 583c1c9 > krita/plugins/tools/tool_polyline/kritatoolpolyline.desktop 3675fce > krita/plugins/tools/tool_text/kritatooltext.desktop b22331d > krita/plugins/tools/tool_transform2/kritatooltransform.desktop 26df4f6 > krita/sdk/templates/docker/krita_APPNAMELC.desktop 6175d62 > krita/sdk/templates/filter/kritaAPPNAMELC.desktop 1eea95d > krita/sdk/templates/tool/kritatoolAPPNAMELC.desktop b2db303 > krita/sdk/templates/view/kritaAPPNAMELC.desktop 6175d62 > krita/ui/kis_factory2.cc 5284f9d > krita/ui/kis_view2.cpp f735776 > libs/basicflakes/plugin/basicflakesplugin.desktop 8b0f232 > libs/flake/KoDockRegistry.cpp 117d382 > libs/flake/KoEventActionRegistry.cpp 100f701 > libs/flake/KoFilterEffectRegistry.cpp 7230ca9 > libs/flake/KoInputDeviceHandlerRegistry.cpp 6cfc37b > libs/flake/KoShapeRegistry.cpp d48c9bb > libs/flake/KoToolRegistry.cpp 0e5ab80 > libs/flake/Mainpage.dox 1866c9b > libs/flake/filtereffect.desktop 2aeac48 > libs/flake/flakeborder.desktop 9fa6239 > libs/kopageapp/tools/backgroundTool/kopabackgroundtool.desktop 0b5c4e1 > libs/koplugin/KoPluginLoader.h 83f7265 > libs/kotext/KoInlineObjectRegistry.cpp 9e5ebb9 > libs/kotext/KoTextEditingRegistry.cpp 477388c > libs/pigment/KoColorSpaceRegistry.cpp 32b4e18 > libs/pigment/pigment.desktop 9fa0494 > libs/pigment/pigmentextension.desktop 1ad1a30 > plan/plugins/scripting/krossmoduleplan.desktop a880a23 > plugins/artistictextshape/artistictextshape.desktop afcba7a > plugins/chartshape/chartshape.desktop f17ea48 > plugins/colorengines/lcms2/colorspaces/gray_u8/calligragrayaplugin.desktop > aeacdfd > plugins/colorengines/lcms2/kolcmsengine.desktop 49cadf1 > plugins/commentshape/commentshape.desktop 5fb7730 > plugins/defaultTools/defaulttools.desktop f9362df > plugins/dockers/calligradockers.desktop bb581a6 > plugins/formulashape/formulashape.desktop f0a7835 > plugins/kexi/spreadsheet/keximigrate_spreadsheet.desktop 4f09ce4 > plugins/musicshape/musicshape.desktop 533723f > plugins/pathshapes/pathshapes.desktop 8735466 > plugins/pictureshape/pictureshape.desktop 8537bb4 > plugins/pluginshape/pluginshape.desktop 0272806 > plugins/spacenavigator/spacenavigator.desktop f0d5ce3 > plugins/staging/templateshape/templateshape.desktop eb72a46 > plugins/staging/threedshape/threedshape.desktop 8b7817f > plugins/textediting/autocorrection/autocorrect.desktop da2bd12 > plugins/textediting/changecase/changecase.desktop eb7d2fd > plugins/textediting/spellcheck/spellcheck.desktop 9720f28 > plugins/textediting/thesaurus/thesaurustool.desktop a4db8fb > plugins/textshape/textshape.desktop f011ba1 > plugins/variables/textvariables.desktop 13dfba8 > plugins/vectorshape/vectorshape.desktop ee546df > plugins/videoshape/videoshape.desktop 1e52292 > sheets/plugins/calendar/kspread_plugin_tool_calendar.desktop f6d7ac7 > sheets/plugins/scripting/krossmodulesheets.desktop 28ef4d0 > sheets/shape/spreadsheetshape-deferred.desktop a304444 > sheets/shape/spreadsheetshape.desktop 4980e6f > stage/part/pageeffects/KPrPageEffectRegistry.cpp 78b9750 > stage/part/shapeanimations/KPrShapeAnimationRegistry.cpp ef6e181 > stage/part/tools/animationtool/calligrastagetoolanimation.desktop f6892fa > stage/plugins/eventactions/calligrastageeventactions.desktop 02b465f > stage/plugins/pageeffects/barwipe/kpr_pageeffect_barwipe.desktop 8ed4249 > stage/plugins/pageeffects/clockwipe/kpr_pageeffect_clockwipe.desktop > 1fb7730 > stage/plugins/pageeffects/edgewipe/kpr_pageeffect_edgewipe.desktop b2c5d98 > stage/plugins/pageeffects/example/kpr_pageeffect_example.desktop f3d2e4f > stage/plugins/pageeffects/fade/kpr_pageeffect_fade.desktop a2f6109 > stage/plugins/pageeffects/iriswipe/kpr_pageeffect_iriswipe.desktop 9470780 > stage/plugins/pageeffects/matrixwipe/kpr_pageeffect_matrixwipe.desktop > cbf1bfb > stage/plugins/pageeffects/slidewipe/kpr_pageeffect_slidewipe.desktop > 499765b > > stage/plugins/pageeffects/spacerotation/kpr_pageeffect_spacerotation.desktop > 244d0d2 > stage/plugins/pageeffects/swapeffect/kpr_pageeffect_swapeffect.desktop > 2667410 > stage/plugins/shapeanimations/example/kpr_shapeanimation_example.desktop > 209cb75 > stage/plugins/variable/kprvariables.desktop 1279be0 > words/plugins/scripting/krossmodulewords.desktop 728994e > > Diff: http://git.reviewboard.kde.org/r/108326/diff/ > > > Testing > ------- > > > Thanks, > > Boudewijn Rempt > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
