----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108295/#review25461 -----------------------------------------------------------
Ship it! It looks neat and clean to me too libs/main/KoApplication.cpp <http://git.reviewboard.kde.org/r/108295/#comment19482> is it just reviewboard or is there some weird indentation going on at least there is a space between ) and ) that shouldn't be there - C. Boemann On Jan. 14, 2013, 1:22 p.m., Stuart Dickson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108295/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2013, 1:22 p.m.) > > > Review request for Calligra. > > > Description > ------- > > In order to allow Calligra applications to be run as pre-built binaries on > Windows operating system, some environment variables need to be set in order > to allow plugins etc to be correctly found. > > Previously, the packaged version of the applications used a combination of > batch file and VBS script in order to set the environment invisibly to the > user before launching the application. > > The patch allows the Calligra binaries (words, sheets, stage, karbon, plan, > flow) to be launched directly. > This also resolves occasional issues where scripting was not correctly > installed, or was not available to the user. > It also makes possible associating the Calligra applications against document > file types. > > > Diffs > ----- > > libs/main/KoApplication.cpp 6a71458 > > Diff: http://git.reviewboard.kde.org/r/108295/diff/ > > > Testing > ------- > > Built and run on Windows system, demonstrated to work with existing packaging > setup. > Modifications are wrapped in an OS-centric block (with the exception of the > additional headers required), so this willl not affect Linux builds. > > > Thanks, > > Stuart Dickson > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
