----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108479/#review25770 -----------------------------------------------------------
Hi I've started to review but it seems there is a recurring them, so please continue fixng the rest of the patch like i'v indicte with my comments for the first part. good work in general - i now it's hard to jump right in and do this :) libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19607> please delete trailing spaces libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19608> please delete trailing spaces libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19609> please delete trailing spaces libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19611> these lines are chnge related too - please remove libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19610> please delete trailing spaces libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19612> these lines are change related too please remove libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19613> please delete trailing spaces libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19614> please delete trailing spaces libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19615> this is change related too please remove libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19616> more change related stuff to be removed libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19617> this if block is change related -remove libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19618> please delete trailing spaces libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19619> this if block is change related too - remove libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19620> this if block is change related - remove libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19621> please delete trailing spaces libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19622> please delete trailing spaces libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19623> please delete trailing spaces - C. Boemann On Jan. 19, 2013, 12:55 a.m., Luke De Mouy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108479/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2013, 12:55 a.m.) > > > Review request for Calligra. > > > Description > ------- > > This strips out the change tracking code in KoTextWriter and KoTextLoader, in > order to lay the groundwork for a new change tracking system and > collaborative editing. > > > Diffs > ----- > > libs/kotext/opendocument/KoTextLoader.h 03856fb > libs/kotext/opendocument/KoTextLoader.cpp d024996 > libs/kotext/opendocument/KoTextWriter.h 357d4bc > libs/kotext/opendocument/KoTextWriter.cpp db5f23d > libs/kotext/opendocument/KoTextWriter_p.h f3466e1 > libs/kotext/opendocument/KoTextWriter_p.cpp 39cf629 > > Diff: http://git.reviewboard.kde.org/r/108479/diff/ > > > Testing > ------- > > > Thanks, > > Luke De Mouy > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
