> On Jan. 18, 2013, 3:07 p.m., Dmitry Kazakov wrote: > > libs/widgets/KoZoomController.cpp, lines 276-278 > > <http://git.reviewboard.kde.org/r/108420/diff/1/?file=107345#file107345line276> > > > > I have such a feeling that this explicit signal emission can be > > removed, because all the code paths above end up with recenterPreferred() > > or setPreferredCenter(), which should emit the signals as well. So we > > probably get duplicated signals here. > > > > Could you check whether it works without these lines? > > > > The rest is ok to commit. > > > >
yes it works just as well without - so removing them - not uploading new diff - cna i get a ship it then? - C. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108420/#review25754 ----------------------------------------------------------- On Jan. 15, 2013, 5:04 a.m., C. Boemann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108420/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2013, 5:04 a.m.) > > > Review request for Calligra and Inge Wallin. > > > Description > ------- > > Introduce a "Fit Text Width" zoom mode > > This also changes how the other "fit" modes work: We now zoom in to the > fit the > max pagesize of the currently shown pages. Previously we zoomed in to the > max > pagesize of the entire document. > > The page counter in the lower left of Words' window now show the scroll > position > and not the cursorposition. Previously it was a weird mix > > The page counter also now shows ranges so that if pages 3,4,5 are shown, > the counter > says "3-5 of 47" > > > Diffs > ----- > > libs/widgets/KoZoomAction.cpp 589b4c7 > libs/widgets/KoZoomController.h 864abb4 > libs/widgets/KoZoomController.cpp 7cb6f06 > libs/widgets/KoZoomMode.h cfaeed8 > libs/widgets/KoZoomMode.cpp 81ffdf4 > words/part/KWStatusBar.cpp f3de247 > words/part/KWView.h 253b8021 > words/part/KWView.cpp 988dba4 > > Diff: http://git.reviewboard.kde.org/r/108420/diff/ > > > Testing > ------- > > only in words, and since it touches libs too I'd like some feedback > > > Thanks, > > C. Boemann > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
