----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108781/#review26639 -----------------------------------------------------------
Hi Thanks for doing this, and don't be alarmed by the number of comments I have given please fix and update the diff afterwards libs/kotext/KoTextEditor_format.cpp <http://git.reviewboard.kde.org/r/108781/#comment20230> this shouldn't be there libs/kotext/KoTextEditor_format.cpp <http://git.reviewboard.kde.org/r/108781/#comment20229> this is not needed libs/kotext/KoTextEditor_format.cpp <http://git.reviewboard.kde.org/r/108781/#comment20228> this line should be kept too. it's very important to "close" the editing (in terms of undo/redo) libs/kotext/KoTextEditor_format.cpp <http://git.reviewboard.kde.org/r/108781/#comment20231> not sure but i think this needs to stay too. unless it's already done in mergeAutoStyle - C. Boemann On Feb. 4, 2013, 6:13 p.m., Sudhendu Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108781/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2013, 6:13 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > ------- > > Moving formatting from old framework to new framework. This patch only > contains for bold. Once this is approved, same can be done for other > formattings as well. > > > Diffs > ----- > > libs/kotext/KoTextEditor_format.cpp 5a35fe8 > libs/kotext/KoTextEditor_undo.cpp 8dba444 > > Diff: http://git.reviewboard.kde.org/r/108781/diff/ > > > Testing > ------- > > Works well for me. > > > Thanks, > > Sudhendu Kumar > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
