> On June 30, 2013, 8:37 a.m., Sune Vuorela wrote: > > afaik, the DEVEL keyword is only used by cpack which no one is using > > (because it is kind of too primitive to be useful and not compliant with > > various rules set up by distributors). It is kind of usable on windows > > though. dunno about mac.
Thanks for review, Sune. Showed me that I need to add more explanation what this patch is about, as it has nothing to do with that DEVEL keyword of cpack :) Will update (but before split off the prefix of the include dirs into a separate patch/review request, orthogonal to this one) - Friedrich W. H. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111306/#review35296 ----------------------------------------------------------- On June 29, 2013, 2:31 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111306/ > ----------------------------------------------------------- > > (Updated June 29, 2013, 2:31 a.m.) > > > Review request for Calligra. > > > Description > ------- > > also... > * add that tag to all libs which install header and > split off header installation in x_DEVEL product guards > * install all calligralib headers in ${INCLUDE_INSTALL_DIR}/calligra > * install all krita headers in ${INCLUDE_INSTALL_DIR}/krita > * start to install also koproperty headers > > > Diffs > ----- > > CMakeLists.txt 53fa5bd > cmake/modules/CalligraProductSetMacros.cmake 17482a6 > cmake/productsets/all.cmake 8e82b40 > cmake/productsets/desktop.cmake 4e85bc8 > interfaces/CMakeLists.txt 36eb42a > kexi/formeditor/CMakeLists.txt 00e0607 > krita/image/CMakeLists.txt 0db29af > krita/image/tiles3/CMakeLists.txt 1222d5a > krita/ui/CMakeLists.txt 78a61c6 > libs/basicflakes/CMakeLists.txt 4750c5f > libs/db/CMakeLists.txt 60e35a7 > libs/flake/CMakeLists.txt 233d3ce > libs/kopageapp/CMakeLists.txt 35db53f > libs/koproperty/CMakeLists.txt 45aa69c > libs/kotext/CMakeLists.txt 8929d8a > libs/kundo2/CMakeLists.txt cf66a13 > libs/main/CMakeLists.txt d74851b > libs/odf/CMakeLists.txt 574f8a5 > libs/pigment/CMakeLists.txt 8cc00e8 > libs/rdf/CMakeLists.txt 875ce13 > libs/textlayout/CMakeLists.txt 3d9edfe > libs/widgets/CMakeLists.txt 38155e7 > libs/widgetutils/CMakeLists.txt bfe64ca > sheets/CMakeLists.txt e0f4a02 > stage/part/CMakeLists.txt 6eaf356 > words/part/CMakeLists.txt 437f443 > > Diff: http://git.reviewboard.kde.org/r/111306/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
