----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112827/#review40363 -----------------------------------------------------------
This review has been submitted with commit 961c791de4786299ce5b7446d1ca8efd81a638fc by Arjen Hiemstra to branch master. - Commit Hook On Sept. 19, 2013, 3:44 p.m., Arjen Hiemstra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112827/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2013, 3:44 p.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Description > ------- > > Krita has a button to choose the view mode for the preset selectors. In > recent times, tagging support was added to KoResourceItemChooser. Now, the > layour of the preset selector in Krita is messed up because the view mode > button is put above the resource chooser, costing valueable vertical space. > This patch removes that button and adds it to KoResourceItemChooser, by > default hidden. It does not actually do anything but provide an attachment > point for the menu that is added by Krita, since the actual view mode change > is dependant on the delegate used. > > > Diffs > ----- > > krita/ui/forms/wdgpaintoppresets.ui bb95281 > krita/ui/widgets/kis_paintop_presets_chooser_popup.cpp 078c572 > libs/widgets/KoResourceItemChooser.h 91ed650 > libs/widgets/KoResourceItemChooser.cpp 62be3c6 > > Diff: http://git.reviewboard.kde.org/r/112827/diff/ > > > Testing > ------- > > Build and run, everything works. > > > File Attachments > ---------------- > > After the change > > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/19/viewmodebutton_after.png > Before the change > > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/19/viewmodebutton_before.png > > > Thanks, > > Arjen Hiemstra > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
