-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112573/
-----------------------------------------------------------
(Updated Oct. 3, 2013, 4:26 p.m.)
Status
------
This change has been discarded.
Review request for Calligra and Boudewijn Rempt.
Bugs: 323489
http://bugs.kde.org/show_bug.cgi?id=323489
Repository: calligra
Description
-------
9611fc67fa4e4dca4d151a3e9c801bbb9ce72c90 was done under the assumption that
KoParts are now only used in the respective applications.
But that missed a few cases, grepping for createKoPart lists those:
* thumbnailer
* Okular ODP plugin
* calligraconverter
The attached patch tries to fix that by not simply using the appname in
KoServiceProvider::readNativeService(), but demanding that the component is
passed. That way each place which uses KoServiceProvider can precisely define
what context should be used.
Not perfect, perhaps an issue for the Qt5 port?
But at least it seems to fix the problem with the thumbnailer for me: now when
it tries to generate the KoPart to render the thumbnail no longer the assert in
KoServiceProvider is hit and I get thumbnails rendered again for all kind of
documents we support, including kra and ora files.
And the apps seem to still work as before.
Not sure about the solution with KisDlgFileLayer, for most simple code changes
I just passed the view as another member, instead of e.g. creating the
mimefilterlist callee side. Left to decide for you, Boud, what best to do there.
Diffs
-----
libs/main/KoVersionDialog.cpp 2f38510
libs/main/KoServiceProvider.cpp e6ab77c
libs/main/KoPart.cpp 56e27b5
libs/main/KoServiceProvider.h 35ca3ac
libs/main/KoMainWindow.cpp 26327aa
libs/main/KoDocument.cpp 622678f
libs/main/KoApplication.cpp 7421107
libs/kopageapp/KoPAView.cpp 2e6400c
krita/ui/widgets/KisFlipbookSelector.cpp 09425fb
krita/ui/dialogs/kis_dlg_file_layer.cpp 46abb0a
krita/ui/dialogs/kis_dlg_file_layer.h cb4dbe0
krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.cpp 49cf62a
Diff: http://git.reviewboard.kde.org/r/112573/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
_______________________________________________
calligra-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/calligra-devel
