----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112584/#review42666 -----------------------------------------------------------
sheets/ui/CellToolBase.cpp <http://git.reviewboard.kde.org/r/112584/#comment30889> Hi Jigar, one thing must have slipped your eyes, the compiler sees three issues in the new code, see http://build.kde.org/job/calligra_master/1681/warnings16Result/new/ Always pay attention to compiler warnings and make sure there are none :) While the first just warns about an unneeded var (though still worth to fix that, for a clean build and no unneeded code), the second two warnings seem indeed hint to a crash just waiting, as the conv and conv2 are nowhere set here in CellToolBase::populateWordCollection() and thus things will crash in this line QString value=conv->toString( conv2->asString(val) ); if it ever will be executed. Please better fix that as soon as you find time :) Cheers Friedrich - Friedrich W. H. Kossebau On Oct. 29, 2013, 8:56 p.m., Jigar Raisinghani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112584/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2013, 8:56 p.m.) > > > Review request for Calligra and Inge Wallin. > > > Repository: calligra > > > Description > ------- > > This feature enables you to save time by just clicking/selecting redundant > entries to fill a cell in the sheet. > > How to use: > 1) Open a file containing some data/ Open a blank file and enter some data > 2) Try entering data in the columns which already contain some data which has > atleast first 3 characters similar to some other entry in the same column > > You can see that a popup appears near your cell which gives you suggestions > based on the text you have entered in the current cell. You can chose any > suggestion by clicking on it or using the arrow keys to navigate through > options and using Tab/Enter to fill in the suggestion in the cell. > > Optimization: > 1) Currently, Autocomplete has been optimized to a large extent by Hash Tables > > Further Optimization possible(but not yet done): > 1) Navigate only through cells which are already populated using nextInRow() > and nextInColumn() to populate the HashTable. > 2) Use thread to populate Hash Table when sheet is loaded. This process if > run in background, can optimize the feature further. > > Further Improvements possible: > 1) Currently, the choices filled in the suggestion list are based on Most > Recently Used 3 entries. Autocomplete can be made smarter by populating the > list with 3 Most Redundant entries but this would increase the complexity and > optimization would again be needed. > > > Diffs > ----- > > sheets/ui/CellEditor.h 92bdad6 > sheets/ui/CellEditor.cpp d539c06 > sheets/ui/CellToolBase.h 0c404ce > sheets/ui/CellToolBase.cpp 512fdbb > sheets/ui/CellToolBase_p.h 9cdadf2 > > Diff: http://git.reviewboard.kde.org/r/112584/diff/ > > > Testing > ------- > > The feature works successfully for fair amount of data. Testing yet to be > done for Huge Files. > > > Thanks, > > Jigar Raisinghani > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
