----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113784/#review43347 -----------------------------------------------------------
Ship it! Ship It! - Cyrille Berger Skott On Nov. 10, 2013, 6:47 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113784/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2013, 6:47 a.m.) > > > Review request for Calligra, Cyrille Berger Skott and Boudewijn Rempt. > > > Repository: calligra > > > Description > ------- > > Looking into why libs-pigment-TestKoColor failed I saw that I failed on > QFATAL : TestKoColor::testChannelsInfo() ASSERT: "cs->profile()->name() == > profileName" in file > /home/koder/Kode/kdegit/Calligra/calligra/libs/pigment/KoColorSpaceRegistry.cpp, > line 355 > for all the LCMS2 XYZ colorspaces. > The default profile name was always "XYZ built-in - (lcms internal)", where > cs->profile()->name() was "XYZ identity built-in". > > Looking at https://github.com/mm2/Little-CMS/blob/master/src/cmsvirt.c I saw > that there "XYZ identity built-in" is used, and seems to have done so for > some years. This pattern also matches the naming expected of the other LCMS > colorspaces in plugins/colorengines/lcms2, so I just assumed that XYZ might > have been forgotten in the port to LCMS2 and did the attached patch, which > made libs-pigment-TestKoColor pass without an error. > > No real clue if this is a proper patch, so passing on to you, Cyrille and > Boud (and who else?). Correct fix? > > > PS: > No idea why libs-pigment-TestKoColorSpaceSanity still fails on , left for you > as well :) > For XYZAF32 this assert triggers: > QFATAL : TestKoColorSpaceSanity::testChannelsInfo() ASSERT: > "profileIsCompatible(p)" in file > /home/koder/Kode/kdegit/Calligra/calligra/plugins/colorengines/lcms2/LcmsColorSpace.h, > line 171 > > > Diffs > ----- > > plugins/colorengines/lcms2/LcmsEnginePlugin.cpp fb9c5a1 > plugins/colorengines/lcms2/colorspaces/xyz_f16/XyzF16ColorSpace.h bd3dd1d > plugins/colorengines/lcms2/colorspaces/xyz_f32/XyzF32ColorSpace.h 62c777f > plugins/colorengines/lcms2/colorspaces/xyz_u16/XyzU16ColorSpace.h 402ca79 > plugins/colorengines/lcms2/colorspaces/xyz_u8/XyzU8ColorSpace.h 7c77b51 > > Diff: http://git.reviewboard.kde.org/r/113784/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
