----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114246/#review45150 -----------------------------------------------------------
CMakeLists.txt <http://git.reviewboard.kde.org/r/114246/#comment32268> Yes, even patch releases can break BC: all calligra libs are currently private. Please note we use "<some_unique_integer_following_minor_version>.0.0". We would have "<some_unique_integer_following_minor_version>.<release>.0" but nothing more. Is that improvement for you? Reference: http://techbase.kde.org/index.php?title=Development/Tutorials/Creating_Libraries#Getting_the_version_numbers_right - Jarosław Staniek On Dec. 1, 2013, 10:35 p.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114246/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2013, 10:35 p.m.) > > > Review request for Calligra, Friedrich W. H. Kossebau, Oleg Kukharchuk, Adam > Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik. > > > Repository: calligra > > > Description > ------- > > Move calligra version variables to cmake defines like in KDElibs > > This exposes version info to CMake scripts. > Extra: SOVERSION is automatically computed. > > > Diffs > ----- > > CMakeLists.txt 6587ecc0eae0b59a5aa401c552b4a1ec6ecba62e > kexi/main/status/CMakeLists.txt de9b09aeea0efba09003c4a0de78c7f2f2e95baa > libs/main/CMakeLists.txt c43696c7b4c37ace2274cf327ef54fb235613095 > libs/main/calligraversion.h 4700d1a233b666c2200cf2df62e35c4b1787df31 > libs/main/calligraversion.h.cmake PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/114246/diff/ > > > Testing > ------- > > master configures, builds and installs, soversion is correct > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
