> On Dec. 13, 2013, 3:25 p.m., Thorsten Zachmann wrote: > > karbon/ui/widgets/KarbonCanvas.cpp, line 156 > > <http://git.reviewboard.kde.org/r/114435/diff/1/?file=224685#file224685line156> > > > > How about just removing the line instead of setting it to false.
Ok to push? - Elvis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114435/#review45653 ----------------------------------------------------------- On Dec. 13, 2013, 3:37 p.m., Elvis Stansvik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114435/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 3:37 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > The page rectangle and margins are strictly horizontal/vertical lines, so I > don't think it makes sense to paint them anti-aliased. They look sharper when > it's turned off. What do you think? (See before/after screenshot). > > > Diffs > ----- > > karbon/ui/widgets/KarbonCanvas.cpp 4737040 > > Diff: http://git.reviewboard.kde.org/r/114435/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Before (with anti-aliasing) > > http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/1e481a13-2d70-4242-bf7d-f10b7bce011a__before.png > After (without anti-aliasing) > > http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/c2057f12-6ee0-4239-8075-6536373a3f30__after.png > > > Thanks, > > Elvis Stansvik > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
