> On Sept. 22, 2014, 11:10 nachm., Jarosław Staniek wrote: > > Almost ready, minor things. > > > > + when I scroll the wheel over a disabled navigator button, my action has > > no effect. Do we need an event filter?
Ah, good catch. Initially I had used event filter, like done in KoPageNavigator. But then I was wondering why that was done and switched to just using the wheelEvent handler method of the base widget. Seems I did not test enough after I switched to that, meh. Seems that a disabled button just eats all events and does not pass them to the parent widget at all: https://qt.gitorious.org/qt/qt/source/10ddcc93c15d2c7bd5126fdb9ed217eb496cc387:src/gui/widgets/qabstractbutton.cpp#L1039 So will add an event filter additionally tomorrow evening. > On Sept. 22, 2014, 11:10 nachm., Jarosław Staniek wrote: > > kexi/widget/utils/kexirecordnavigator.cpp, line 278 > > <https://git.reviewboard.kde.org/r/120272/diff/1/?file=313279#file313279line278> > > > > How about we're removing the Qt::WheelFocus from focusPolicy? Would > > this avoid stealing the focus? Not sure what you would like to see avoided here? I copied the behaviour from the KoPageNavigator: if the focus was in the record number editor, then the focus is removed from editor field and passed back to the view. Reasoning is that the user switched to another tool to select the record/page, the scrollwheel, so away from the editor field. This behaviour is also consistent with what happens as if the user clicks a navigator button when the editor field has the focus before. - Friedrich W. H. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120272/#review67246 ----------------------------------------------------------- On Sept. 18, 2014, 7:40 nachm., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120272/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 7:40 nachm.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > Scroll wheel up is translates to previous button, while scroll wheel down is > to next. > Matches behaviour found in other navigator places, where down means next and > up previous. > (That is different from behaviour in value entering fields, where up means > bigger numbers and down means smaller numbers) > > Which bug report was this requested in? Could not find one yet. > > > Diffs > ----- > > kexi/widget/utils/kexirecordnavigator.h a9a5e12 > kexi/widget/utils/kexirecordnavigator.cpp 1836d21 > > Diff: https://git.reviewboard.kde.org/r/120272/diff/ > > > Testing > ------- > > Tested both with record navigation and with page navigation in reports. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
