> On Jan. 1, 2015, 8:18 p.m., Friedrich W. H. Kossebau wrote: > > Added some more defects I found on the wiki page. Looking into header not > > resizing currently. > > Jarosław Staniek wrote: > Thanks, categorized them now to major/minor/wishes. Do you think no major > "data loss?" defects are known? If so how about pushing the code and > continuing the fixes in individual commits? > > Friedrich W. H. Kossebau wrote: > Cannot remember that I encountered any data loss defects, so would not > object because of that. Your call, if the regressions will be quicker > resolved there ;) > > In general more inspiration from QTableView code might possibly not hurt, > at least QTableView::updateGeometries() looks different not only for header > handling, see > https://qt.gitorious.org/qt/qt/source/62323e8d1b16167662c85e412d35804418593cc6:src/gui/itemviews/qtableview.cpp#L2026
Thanks! As you might see at https://community.kde.org/Kexi/Porting_to_Qt%26KDE_4#Table_View I've marked minor issue #2 as fixed already. A fix for major #1 is almost done. If you click Ship It, I'll be able to push further idividual commits or put for review non-trivial ones :) - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121625/#review72874 ----------------------------------------------------------- On Dec. 29, 2014, 10:28 p.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121625/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 10:28 p.m.) > > > Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. > Kossebau, Adam Pigg, Radosław Wicik, and Wojciech Kosowicz. > > > Repository: calligra > > > Description > ------- > > Finally! A port that took 6 months, now largely functional. Changes are so > cross-dependent, it's hard to split to smaller patches that result in > something stable. > > Changes along the way: > * Harmonize API related to sorting with the Qt API > * Port and clean up current column highlighting > * Make shortcuts work > * Make arrow keys ignore modifiers > * Ensure the current cell is visible before trying to remove current record > * Use separate macro for enabling painting debug > * Use row, then col as args in cellSelected() and paintCell() methods (per > convention of Qt) > This also fixes on ensureCellVisible() call when the args where swapped by > mistake. > * If possible don't move pos of current selection after sorting > * Rename record -> row in table view for more generic API > * Clicking on vertical header selects row > * Hovering on vertical header highlights row > * Display current record pointer as icon > * Show mouse highlight in the vertical header when needed > * Support leave event > * Fix sizes and buttons in record navigator > * Make parameter names consistent > * Fix column resizing, column sorting, painting on scroll > * Fix initializing widths of table columns > * Remove unused variable and excessive debug > * Put horizontal scrollbar aside of the record navigator when possible (but > don't cover the navigator) > > New features: > * Lighter style of rows > * Display "key" icon in primary key columns > > > Diffs > ----- > > kexi/widget/tableview/kexidatatable.cpp f75e736 > kexi/widget/tableview/kexidatatableview.h 53f2a61 > kexi/widget/tableview/kexiblobtableedit.cpp bece46f > kexi/widget/tableview/kexicomboboxbase.cpp d64439d > kexi/widget/tableview/kexicomboboxpopup.h d08ece2 > kexi/widget/tableview/kexicomboboxpopup.cpp 4eba57b > kexi/widget/tableview/kexicomboboxtableedit.cpp 2ee4a0c > kexi/widget/tableview/kexidatatable.h b64cbb7 > kexi/widget/tableview/KexiTableScrollAreaWidget.cpp PRE-CREATION > kexi/widget/tableview/KexiTableScrollArea_p.h PRE-CREATION > kexi/widget/tableview/KexiTableScrollArea_p.cpp PRE-CREATION > kexi/widget/tableview/KexiTableScrollAreaHeader.cpp PRE-CREATION > kexi/widget/tableview/KexiTableScrollAreaHeaderModel.h PRE-CREATION > kexi/widget/tableview/KexiTableScrollAreaHeaderModel.cpp PRE-CREATION > kexi/widget/tableview/KexiTableScrollAreaWidget.h PRE-CREATION > kexi/widget/tableview/KexiTableScrollAreaHeader.h PRE-CREATION > kexi/widget/tableview/KexiDataTableScrollArea.cpp PRE-CREATION > kexi/widget/tableview/KexiDataTableView.h PRE-CREATION > kexi/widget/tableview/KexiDataTableView.cpp PRE-CREATION > kexi/widget/tableview/KexiTableScrollArea.h PRE-CREATION > kexi/widget/tableview/KexiTableScrollArea.cpp PRE-CREATION > kexi/widget/tableview/kexidatatableview.cpp 62c8760 > kexi/widget/tableview/kexitableedit.h 6da77e3 > kexi/widget/tableview/kexitableedit.cpp ff44b7c > kexi/widget/tableview/kexitableview.h 86e5446 > kexi/widget/tableview/kexitableview.cpp 492b8a8 > kexi/widget/tableview/kexitableview_p.h 38fae7b > kexi/widget/tableview/kexitableview_p.cpp 1f64f52 > kexi/widget/tableview/kexitableviewheader.h 1201f2b > kexi/widget/tableview/kexitableviewheader.cpp fcf3ade > kexi/widget/utils/CMakeLists.txt 6942aaa > kexi/widget/utils/kexirecordmarker.h db024f2 > kexi/widget/utils/kexirecordmarker.cpp 5ed82e4 > kexi/widget/utils/kexirecordnavigator.h 7bb8b12 > kexi/widget/utils/kexirecordnavigator.cpp dd47b2c > libs/db/tableviewcolumn.h f2370bc > libs/db/tableviewcolumn.cpp 0687b0b > libs/db/tableviewdata.h 42523c4 > libs/db/tableviewdata.cpp e4660a0 > kexi/plugins/tables/kexitabledesigner_dataview.cpp 34ae4ef > kexi/plugins/tables/kexitabledesignerview.h cfec74b > kexi/plugins/tables/kexitabledesignerview.cpp 7aca480 > kexi/plugins/tables/kexitabledesignerview_p.h c52bd0b > kexi/plugins/tables/kexitabledesignerview_p.cpp 9b2dcbd > kexi/plugins/tables/kexitablepart.cpp b8fd0d7 > kexi/tests/newapi/tableview_test.h 092c2ff > kexi/widget/dataviewcommon/kexidataawareobjectiface.h fe8a2de > kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 948ba5d > kexi/widget/dataviewcommon/kexidataawarepropertyset.h a131b89 > kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp 779b24e > kexi/widget/dataviewcommon/kexidataawareview.h 6604bd2 > kexi/widget/dataviewcommon/kexidataawareview.cpp 5473ec7 > kexi/widget/tableview/CMakeLists.txt 24e1cf1 > kexi/widget/tableview/KexiDataTableScrollArea.h PRE-CREATION > kexi/plugins/queries/kexiquerydesignerguieditor.cpp 9538688 > kexi/plugins/queries/kexiqueryview.h b987d81 > kexi/plugins/queries/kexiqueryview.cpp 2206214 > kexi/plugins/reports/kexireportview.cpp 047f949 > kexi/plugins/tables/kexitabledesigner_dataview.h ea9aba0 > kexi/pics/tableview_plus.xpm de7019b > kexi/pics/tableview_pointer.png PRE-CREATION > kexi/pics/tableview_pointer.xpm PRE-CREATION > kexi/plugins/forms/CMakeLists.txt b9ce947 > kexi/plugins/forms/kexiformscrollview.h f4aa2e2 > kexi/plugins/forms/kexiformscrollview.cpp fbfa560 > kexi/plugins/forms/kexiformview.h 2932861 > kexi/pics/tableview_plus.png bc858050cf2bd3bb6d83f4b590817074e816658c > kexi/pics/tableview_pen.xpm 3d2bd3e > kexi/pics/tableview_pen.png f91eacf63e604300ca563a48bd749cde5d33cb6c > kexi/CMakeLists.txt 55eac5b > kexi/formeditor/connectiondialog.h 627499e > kexi/formeditor/connectiondialog.cpp 469e78a > > Diff: https://git.reviewboard.kde.org/r/121625/diff/ > > > Testing > ------- > > Tested on tables and query designer: functional > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
