----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122240/ -----------------------------------------------------------
Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz. Repository: calligra Description ------- Improve Kexi data-aware cell editing API Plus #1: table view's methods for [editor creation/column width change] now use specified column/row number instead of current ones. Plus #2: in addNewRecordRequested() we're avoiding closing editor before cursor position gets changed (programatically) and avoiding ensuring cell visibility prior to creating the editor. This can enable implementing animations in the future. Diffs ----- kexi/plugins/forms/kexiformscrollview.h beb63430de4b8de8199a4351cf50a5804d2e2525 kexi/plugins/forms/kexiformscrollview.cpp 652a38ab5e92f2e58db1a8a2db215d40ebba327e kexi/widget/dataviewcommon/kexidataawareobjectiface.h f7497bb3fff133fa60905c1ebbe50baf9a213593 kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 917000f078e761a13f267f646bbf91eec73b8f9b kexi/widget/tableview/KexiTableScrollArea.h 42e11f650b437a8f326bd816dfb787d03fad7569 kexi/widget/tableview/KexiTableScrollArea.cpp 485aa22a09cafe5dd2a68a5ad0e2df766cbd64d3 Diff: https://git.reviewboard.kde.org/r/122240/diff/ Testing ------- functionality of table views remain unchanged Thanks, Jarosław Staniek
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
