----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123471/#review79356 -----------------------------------------------------------
Cool! kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.cpp (line 114) <https://git.reviewboard.kde.org/r/123471/#comment54205> Style: 4 times: if( -> if ( ){ -> ) { kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.cpp (line 115) <https://git.reviewboard.kde.org/r/123471/#comment54207> Recommended simpler, less error-prone code: KoProperty::Property &property = set["latitude"]; if (!property.isNull()) { (x 4) kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.cpp (line 36) <https://git.reviewboard.kde.org/r/123471/#comment54210> Please explain in a comment here, why is remembering this values needed. plugins/reporting/maps/KoReportItemMaps.cpp (line 78) <https://git.reviewboard.kde.org/r/123471/#comment54206> if you fix other i18n's, i18n("longitude") -> i18n("Longitude") is worth doing plugins/reporting/maps/KoReportItemMaps.cpp (line 94) <https://git.reviewboard.kde.org/r/123471/#comment54208> External dependency, unsafe. Better is "earth/srtm/srtm.dgml". plugins/reporting/maps/KoReportItemMaps.cpp (line 95) <https://git.reviewboard.kde.org/r/123471/#comment54209> Why is this needed? - Jarosław Staniek On April 22, 2015, 10:57 p.m., Radosław Wicik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123471/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 10:57 p.m.) > > > Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam > Pigg, Jarosław Staniek, and Dimitrios Tanis. > > > Repository: calligra > > > Description > ------- > > Kexi: MapBrowser: Improved properties for forms and reports > > > Diffs > ----- > > kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.h > d8f9da52ed8814c35b1013f909940e50cf9b2383 > kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.cpp > c86462ea5fa6663351687ab4a26c9c853b450d05 > kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.h > ffaea65f0be222373ec84a93c26e96b53bd03fc1 > kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.cpp > df9ad7ea25c37a084d69019a9d4fcb6c22a11fdf > libs/koproperty/editors/spinbox.cpp > 17638610389773174461f6ff63fcae08aa4f2d95 > plugins/reporting/maps/KoReportItemMaps.cpp > c862655006b9f8423be48f1eafa053573dd1f06b > > Diff: https://git.reviewboard.kde.org/r/123471/diff/ > > > Testing > ------- > > Manual testing > > > Thanks, > > Radosław Wicik > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
