danders updated this revision to Diff 6382.
danders marked an inline comment as done.
danders added a comment.
KoResourcePaths: Fix review comments
- Use COMPILING_TESTS instead of NDEBUG
- Variable l -> location
- Improve api docs, fix typos
- Fix debug according to norm, remove ko prefix, move to WidgetsDebug.*
Review by staniek
REPOSITORY
rCALLIGRA Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2577?vs=6267&id=6382
REVISION DETAIL
https://phabricator.kde.org/D2577
AFFECTED FILES
libs/widgets/KoResourcePaths.cpp
libs/widgets/KoResourcePaths.h
libs/widgets/WidgetsDebug.cpp
libs/widgets/WidgetsDebug.h
libs/widgets/tests/CMakeLists.txt
libs/widgets/tests/KoResourcePathsTest.cpp
libs/widgets/tests/KoResourcePathsTest.h
libs/widgets/tests/patch
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: danders, Calligra-Devel-list, staniek, #calligra:_3.0
Cc: staniek
