boemann added inline comments.
INLINE COMMENTS
> KoTextLayoutNoteArea.cpp:143
> +
> + if (blockLayoutLine.isValid()) {
> + d->labelYOffset += blockLayoutLine.ascent();
I'm fine with this change
> KoTextLayoutTableArea.cpp:464
> + //if we couldn't fit the header rows
> + //try again don't reset cursor->row or we enter infinite loop
> + //cursor->row = 0;
nah this is too aggressive.
There are definitely cases where setting to 0 is the correct thing to do.
There might be some times we enter an infinite loop yes, but we need to catch
this is some other way
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D15428
To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
