Yeah.. Fixed now.. To make it easier
I added a isRunAllowed() method to the base ServiceSupport class.
On 10/5/07, William Tam <[EMAIL PROTECTED]> wrote:
> Thanks Hiram. Should we add a check for !isStopped() here as well?
>
> if (exchange != null && !isStopping()) {
> processor.process(exchange, new AsyncCallback() {
> public void done(boolean sync) {
> }
> });
> }
>
>
> On 10/5/07, Hiram Chirino <[EMAIL PROTECTED]> wrote:
> > On 10/4/07, Hiram Chirino <[EMAIL PROTECTED]> wrote:
> > > On 10/4/07, William Tam <[EMAIL PROTECTED]> wrote:
> > > > 2. In the SedaConsumer.run() method. I think the two checks for
> > > > "!isStopping()" should be modified to: "!isStopping() &&
> > > > !isStopped()". Otherwise, the consumer's thread can run forever since
> > > > it is possible for ServiceSupport.stop() to change the stopping flag
> > > > to true and back to false before the consumer's thread has a chance to
> > > > check the stopping flag.
> > >
> > > Good catch! Will fix.
> > >
> >
> > fixed in rev 582282
> >
> > > >
> > > > Regards,
> > > > William
> > > >
> > >
> > >
> > > --
> > > Regards,
> > > Hiram
> > >
> > > Blog: http://hiramchirino.com
> > >
> >
> >
> > --
> > Regards,
> > Hiram
> >
> > Blog: http://hiramchirino.com
> >
>
--
Regards,
Hiram
Blog: http://hiramchirino.com
