[ 
https://issues.apache.org/activemq/browse/CAMEL-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hadrian Zbarcea reassigned CAMEL-272:
-------------------------------------

    Assignee: Hadrian Zbarcea  (was: Hadrian Zbarcea)

> Rework of File Component to Remove Tangles and simplify code
> ------------------------------------------------------------
>
>                 Key: CAMEL-272
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-272
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: Christian Schneider
>            Assignee: Hadrian Zbarcea
>             Fix For: 1.4.0
>
>         Attachments: file-test.zip, file.zip, new no tangles.png, old.png, 
> patch.txt, patchfile.txt
>
>
> After my first smaller rework in issue camel-262 I now completely reworked 
> the file component to remove any cyclic references and clean up the code.
> The first thing I did was separating the FileComponent from the other classes 
> in package file by moving them to a new package .impl. This way I was able to 
> remove the cycle between the strategy package and the file package.
> The second step was to move all config data from FileEndPoint to a new class 
> FileEndPointConfig. This way I was able to remove the cycle between 
> FileEndPoint, FileProducer and FileConsumer.
> Next I removed FileMessage and FileExchange and instead relied on the default 
> objects. The file is simply stored in DefaultMessage.body. There was even a 
> comment in the code asking if FileExchange was necessary before. So I hope 
> this is ok?
> I had to adapt the tests to the new structure but only changed the tests 
> where it was absolutely necessary. All tests run fine.
> What do you think?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to