Since your are meeting with a known issue which filled in JIRA, so I comment out the unit test to let bamboo keep running. If you take a look at bamboo's building log , you will find that it will not build the remain modules if it get a test failure. Maybe we need change the bamboo's build scrip to let it use -fae ( fail at end) options.

BTW, We are going to release Camel 1.4.0 this week, if we can't get your issue fixed on time , I'd like to comment it out for moving it into the 1.5.0.

The JIRA for your issue could keep the unit test in our mind :)

Willem
Aaron Mulder wrote:
So I've been wrangling with various scripting languages in Camel expressions.

I think I've determined that JavaScript and Python are broken, because
the expressions when invoked via JSR-223 always evaluate to null or
false.  It looks like that might be fixed by changing the way the
script is invoked.

Anyway, James asked me to put in unit tests to demonstrate the
problem, so I did.  Unfortunately, there are a number of unit tests in
the camel-script module that were previously failing and commented
out, for reasons that aren't clear to me (though I didn't really
investigate).

The problem is, someone immediately commented out my new unit tests
too, because they caused the Bamboo build to fail.  And that's a
problem because now they're just in the mess of "failing unit tests
being ignored" instead of "failing tests demonstrating a problem that
needs to be fixed".

So I guess I'd like to ask that the Bamboo maintainer not comment out
these tests, even though it will cause the build to fail if tests are
enabled.  If that's not acceptable, if all failing unit tests will
just be commented out, then it seems to me there's little reason to
*write* unit tests.  But I'm open to suggestions on this one.

Thanks,
      Aaron


Reply via email to