[ 
https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44650#action_44650
 ] 

Claus Ibsen commented on CAMEL-757:
-----------------------------------

Vadim, nice patch. I have a few comments:

- Would be nice with INFO logging in doStart() about connecting to ... so 
end-users can see what room / chat server / whatever is connected to (there is 
an if .. else in the start code)
- You can fix the TODO about the swallowing exceptions by wrapping in a 
CamelRuntimeExchangeException or what is is called - see mail on dev forum

And then is there any new stuff that needs to be updated in the wiki as well?

> Add room support in consumer mode
> ---------------------------------
>
>                 Key: CAMEL-757
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-757
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-xmpp
>    Affects Versions: 1.4.0
>            Reporter: Vadim Chekan
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: diff.txt
>
>
> Currently XmppEndpoint support room only for producer but not for consumer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to