[
https://issues.apache.org/activemq/browse/CAMEL-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46420#action_46420
]
Claus Ibsen commented on CAMEL-983:
-----------------------------------
Bruce did a review and the code in the patch should use continue and not return
false:
Hi
Ah of course it should be continue ;) I coded it with the laptop on my lap on
the couch with the wife grumping why I looked at the computer and not hear. But
I wanted quickly to throw in some code for review and suggestions.
I was a bit surprised to not find an API to be able to easier identify if a
method is overridden. I have been working with the IDEA API for my generate
toString() plugin for 6+ years and they have such a nice API where you can get
tons of information about your code.
I would like the change to be tested more thoroughly before we can commit it.
So feel free to add more unit tests that test with more methods in the
inherited classes, without inheritance etc. We are closing in on 1.5 and I
would be sad to break something this late in the game.
> BeanInfo - should consider overridden methods when selecting method from
> operations list
> ----------------------------------------------------------------------------------------
>
> Key: CAMEL-983
> URL: https://issues.apache.org/activemq/browse/CAMEL-983
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 1.4.0
> Reporter: Claus Ibsen
> Attachments: CAMEL-983.patch
>
>
> See nabble:
> http://www.nabble.com/BeanInfo.chooseMethodWithMatchingBody-throws-an-AmbiguousMethodCallException-when-there%27s-no-ambiguity-td19959124s22882.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
