[
https://issues.apache.org/activemq/browse/CAMEL-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48172#action_48172
]
Claus Ibsen commented on CAMEL-1159:
------------------------------------
Hi William
The OUT batch size was something I added recently for the aggregator, needed by
end-users.
Martin Krasser (contributer with great patches for aggregator, resequencer,
splitter etc.) said he would create a patch with the IN / OUT batch options in
his xxxConfig objects (etc StreamResequencerConfig).
So we might need to check the wiki
- splitter
- resequencer
- aggregator
That the batch size options is documented. See aggregator that has this
documentation (batch options). So if the splitter and resequencer now also
supports the OUT batch size then we should copy the documentation (batch
options) to their wiki page as well.
And maybe the OUT batch size should be exposed on
- the fluent builders
- the xxxConfig objects (StreamResequencerConfig and the other one)
> Check the logic in Aggregator.isBatchCompleted()
> ------------------------------------------------
>
> Key: CAMEL-1159
> URL: https://issues.apache.org/activemq/browse/CAMEL-1159
> Project: Apache Camel
> Issue Type: Task
> Components: camel-core
> Reporter: William Tam
> Assignee: William Tam
> Fix For: 2.0.0
>
>
> Understand the logic of this method and also see if the protected method
> getCollection() is really needed (or getCollectionSize() is suffice). The
> reason being supporting the getCollection() method may constraint the
> BatchProcessor class to implement less efficient algorithm.
> {code}
> @Override
> protected boolean isBatchCompleted(int index) {
> if (aggregationCompletedPredicate != null) {
> // TODO: (davsclaus) What is the point with this code? I think
> its wrong
> if (getCollection().size() > 0) {
> return true;
> }
> }
> return super.isBatchCompleted(index);
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
