[
https://issues.apache.org/activemq/browse/CAMEL-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48377#action_48377
]
Claus Ibsen commented on CAMEL-1203:
------------------------------------
This is awesome.
Just looked at the patch as I was curious on the restless.
- class MethodBasedRouter is not public I guess it's on purpose
- DefaultRestletBinding can the stuff William Tam introduced
(HeaderFilterStrategy) with header filters be used?
- request.setReferrerRef("camel-rest"); maybe camel-restlet is better?
- DefaultRestletBinding you are populating both exchange IN and OUT with the
same body. What's the reason? Please add code comments as it's not common to do
- Are there other instance that can cause XML media type than the 2 we have now?
- Would be nice to DEBUG the media type resolved
- Should the media type be taking into account when going from restlet to
camel? Maybe added as a message header
- Logging in RestletComponent could be polished a bit for better text/wording
(starting server, adding to server etc.)
- How is the server stopped? (when component is stopped?)
- In Producer maybe adding a DEBUG/TRACE logging when client received a
response so you can see the response has been retrieved to it
- In Producer buildUri can be static method
- Please javadoc all parameters and etc. in interfaces such as RestletBinding
- In Consumer please use ObjectHelper.wrapRuntimeCamelException for rethrowing
Exception as it could be a RuntimeCamelException we dont want to double wrap.
Check code in camel-core for examples. And don't log it ;). Or simply maybe
don't do any try .. catch at all
> REST (Restlet based) component
> ------------------------------
>
> Key: CAMEL-1203
> URL: https://issues.apache.org/activemq/browse/CAMEL-1203
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Przemyslaw Budzik
> Assignee: William Tam
> Attachments: CAMEL-1203.patch, camel-restlet.patch
>
>
> This is the code I was talking with James which we are using in SubRecord. It
> is minimalistic, but does its job for both consumer and producer and is very
> easy to use. If you want could be a replacement for the current camel-rest
> (or could be merged).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
