Should we make this default a configuration parameter?

Paul

On 20 March 2010 09:18, Supun Kamburugamuva <[email protected]> wrote:

> On Sat, Mar 20, 2010 at 2:16 PM, Supun Kamburugamuva <[email protected]>
> wrote:
> > On Fri, Mar 19, 2010 at 4:36 PM, Ruwan Linton <[email protected]> wrote:
> >> Supun Kamburugamuva wrote:
> >>> In Case of GET and if there is no content type Synapse NHTTP transport
> >>> handles it in a different way. In this case Nhttp transport doesn't
> >>> call the builder and creates an empty SOAP envelope and set it to the
> >>> message context. So this works with the Nhttp transport.
> >>>
> >> Hhhmmm... where is that logic Supun?? I am sorry I don't see such a
> >> logic on the nhttp transport. at least on trunk. Nhttp transport
> >> delegates the actual processing to the
> >> org.apache.axis2.transport.http.util.RESTUtil#processURLRequest method.
> >>
> >> :-(
> >>
> >> Am I missing something?
> >>
> >
> > May be I'm missing something :). But with the 3.0.0 release even if
> > there is no content type in the incoming XML, Synapse handles it
> > correctly. Need to investigate this further.
> >
>
> Yes I was missing something :). If the content type is null for a GET
> request, it is default to application/x-www-form-urlencoded in  the
> org.apache.axis2.transport.http.util.RESTUtil.java.
>
> if (contentType == null || "".equals(contentType)) {
>    contentType = HTTPConstants.MEDIA_TYPE_X_WWW_FORM;
> }
>
> Thanks,
> Supun..
>
> > Thanks,
> > Supun..
> >
> >> Thanks,
> >> Ruwan
> >>> Thanks,
> >>> Supun..
> >>>
> >>> On Fri, Mar 19, 2010 at 2:54 PM, Sanjiva Weerawarana <[email protected]>
> wrote:
> >>>
> >>>> On Fri, Mar 19, 2010 at 2:43 PM, Supun Kamburugamuva <[email protected]>
> wrote:
> >>>>
> >>>>> Yes there is the problem with the default builder as well. Ideally we
> >>>>> should be able to configure this in the axis2.xml's messageBuilders
> >>>>> configuration. How about having a defaultBuilder configuration
> >>>>> attribute for the message builders in the axis2.xml? We can put this
> >>>>> to the messageFormatters as well.
> >>>>>
> >>>> +1 but that needs to go to d...@axis.
> >>>>
> >>>>> Regarding the Roberto's problem, there was a real issue with the GET
> >>>>> requests and message relay. We've fixed this in the 3.0.0 release.
> >>>>>
> >>>> Yes but it still won't work for him because his GET has no media type.
> So we
> >>>> need a default builder option before it'll work right?
> >>>>
> >>>> Sanjiva.
> >>>> --
> >>>> Sanjiva Weerawarana, Ph.D.
> >>>> Founder, Chairman & CEO; WSO2, Inc.;  http://wso2.com/
> >>>> email: [email protected]; phone: +1 408 754 7388 x51726; cell: +94 77
> 787
> >>>> 6880
> >>>> blog: http://sanjiva.weerawarana.org/
> >>>>
> >>>> Lean . Enterprise . Middleware
> >>>>
> >>>> _______________________________________________
> >>>> Carbon-dev mailing list
> >>>> [email protected]
> >>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
> >>>>
> >>>>
> >>>>
> >>>
> >>> _______________________________________________
> >>> Carbon-dev mailing list
> >>> [email protected]
> >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
> >>>
> >>>
> >>
> >>
> >> --
> >> Ruwan Linton
> >> Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb
> >> WSO2 Inc.; http://wso2.org
> >> phone: +1 408 754 7388 ext 51789
> >> email: [email protected]; cell: +94 77 341 3097
> >> blog: http://blog.ruwan.org
> >>
> >> Lean . Enterprise . Middleware
> >>
> >>
> >> _______________________________________________
> >> Carbon-dev mailing list
> >> [email protected]
> >> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
> >>
> >
>
> _______________________________________________
> Carbon-dev mailing list
> [email protected]
> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>



-- 
Paul Fremantle
CTO and Co-Founder, WSO2
OASIS WS-RX TC Co-chair, VP, Apache Synapse

Office: +44 844 484 8143
Cell: +44 798 447 4618

blog: http://pzf.fremantle.org
twitter.com/pzfreo
[email protected]

wso2.com Lean Enterprise Middleware
_______________________________________________
Carbon-dev mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to