Some comments on generated DBS file: 1. Query IDs: Are we using camel case? e.g. selectAll_jk_test_table_1Query. I understand the table name is jk_test_table_1 (and yes we can have anything here, as it comes from the DB). But why do we have "selectAll_" as prefix and "Query" as suffix and not "_Query". Same applied to other query types as well. 2. Should we have "select_all_" as prefix and "_query" as suffix? Basically, all lower case. Same applied to other query types as well. 3. "selectAll" vs "selectFrom". I do not think "selectFrom" is the correct prefix. Because, even "selectAll" uses "SELECT * FROM" in the query. The main difference between them is "WHERE". So why not use "selectWhere", (or "select_where" as per 2) here? "selectFrom" confused me when I had a first look at the dbs, and I had to look back at select all, to understand the difference. We should also consider something like "select_with_key" as prefix for this, as that makes it more readable 4. Why use "add_" for INSERT and not "insert_" as the prefix. That looks out of the bunch as all other operations use the same SQL keyword as operation prefix 5. The same concerns raised from 1 to 4 above apply to operation IDs as well, except for the operation name suffix 6. Why not use "_operation" or at least "_op" as suffix for operation name? 7. Why not use "_data_service" or at least "_ds" as suffix for service name rather than just the table name? For e.g. if table name was "wes_client" make the service name "wes_client_data_service"
In summary, we need consistency and also focus on readability, for the sake of maintainability, of the DBS. We cannot rule our someone trying to read this and understand what it is all about. I presume users will use this as the first step and then customize this manually to suite their needs. May be we should define some best practices to be followed when implementing DBS files, in general, and follow those guidelines in the generated file as well. Not sure if we already have guidelines on how to write a good DBS - if not we can make that part of this effort. Thanks, Samisa... On Sat, May 1, 2010 at 10:16 PM, Jasintha Dasanayaka <jasin...@wso2.com>wrote: > Hi > > Here I attached both wsdl and dbs which generated for one table service. > > Thanks > Jasintha > > > On Sat, May 1, 2010 at 1:49 PM, Amila Suriarachchi <am...@wso2.com> wrote: > >> hi, >> >> Can you please send the generated wsdl for one table service? >> >> I am not sure how you have done it. Here you can nicely map insert, >> delete, update, select to four operations called put, delete, post and get. >> Then expose it as restful service[1]. >> >> [1] http://wso2.org/library/3726 >> >> thanks, >> Amila. >> >> >> >> >> On Fri, Apr 30, 2010 at 2:48 PM, Jasintha Dasanayaka >> <jasin...@wso2.com>wrote: >> >>> Hi All >>> >>> I have finished the development of all the basic functionality of the UI >>> wizard. Some screen shots are attached. >>> >>> Thanks >>> Jasintha >>> >>> On Fri, Apr 23, 2010 at 2:50 PM, Jasintha Dasanayaka >>> <jasin...@wso2.com>wrote: >>> >>>> It's a wizard. Following are the usage scenarios. >>>> Create >>>> 1. Select a data source >>>> 2. Select set of database objects of this data source >>>> 3. Generate data services for selected objects >>>> >>>> View/Edit >>>> 1. Select a data source & view existing data services created for it's >>>> objects. >>>> >>>> thanks >>>> Jasintha >>>> >>>> >>>> On Fri, Apr 23, 2010 at 2:33 PM, Samisa Abeysinghe <sam...@wso2.com>wrote: >>>> >>>>> >>>>> >>>>> On Fri, Apr 23, 2010 at 2:20 PM, Jasintha Dasanayaka < >>>>> jasin...@wso2.com> wrote: >>>>> >>>>>> Hi All >>>>>> >>>>>> I am developing a new feature for data-service .It can uses >>>>>> to generate data services for given database. It generates data >>>>>> services for whole database. >>>>>> >>>>>> It generates one service per one table that service has basic >>>>>> database operations(Insert, Delete, Update, Select by key and Select >>>>>> all). >>>>>> >>>>>> >>>>>> This feature basically has two parts ,UI part and the back end >>>>>> part.The back end part of the feature I have already developed now i am >>>>>> developing the UI part of the feature. >>>>>> I expect to complete this UI part with in the next week >>>>>> >>>>> >>>>> What does the UI do? I mean does it allow configuring, or viewing, or >>>>> is it a Wizard?? >>>>> >>>>> Samisa... >>>>> >>>>> >>>>>> >>>>>> thanks >>>>>> Jasintha >>>>>> >>>>>> -- >>>>>> Jasintha Dasanayaka >>>>>> email: jasin...@wso2.com >>>>>> cell: +94 772 916 596 >>>>>> blog: http://jasintha.org >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Carbon-dev mailing list >>>>>> Carbon-dev@wso2.org >>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>>>>> >>>>>> -- >>>>> Samisa Abeysinghe >>>>> Director, Engineering - WSO2 Inc. >>>>> >>>>> http://wso2.com/ - "lean . enterprise . middleware" >>>>> >>>>> >>>>> _______________________________________________ >>>>> Carbon-dev mailing list >>>>> Carbon-dev@wso2.org >>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Jasintha Dasanayaka >>>> email: jasin...@wso2.com cell: +94 772 916 596 >>>> blog: http://jasintha.org >>>> >>>> >>> >>> >>> -- >>> Jasintha Dasanayaka >>> email: jasin...@wso2.com cell: +94 772 916 596 >>> blog: http://jasintha.org >>> >>> >>> _______________________________________________ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> _______________________________________________ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Jasintha Dasanayaka > email: jasin...@wso2.com cell: +94 772 916 596 > blog: http://jasintha.org > > > _______________________________________________ > Carbon-dev mailing list > Carbon-dev@wso2.org > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Samisa Abeysinghe Director, Engineering - WSO2 Inc. http://wso2.com/ - "lean . enterprise . middleware"
_______________________________________________ Carbon-dev mailing list Carbon-dev@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
