On Tue, Sep 28, 2010 at 9:12 PM, Charith Wickramarachchi <[email protected]>wrote:
> > > On Tue, Sep 28, 2010 at 9:02 PM, Hiranya Jayathilaka <[email protected]>wrote: > >> >> >> On Tue, Sep 28, 2010 at 10:49 AM, Amila Jayasekara <[email protected]>wrote: >> >>> Hi All, >>> I am using a separate maven profile to run findbugs. Thus if there >>> are find bugs issues, the maven build will fail. This will be >>> advantageous in long run. >> >> >> I'm -1 for adding this to the build profiles. Our build process already >> takes long enough. >> >> IMO the individual developers should be responsible and considerate enough >> to do this at development time. That should be part of the development >> "protocol". If somebody doesn't adhere to that it's a different matter. We >> should have notifications in place to track such practices. >> >> eg: >> A commit hook which analyzes the code for formatting and comments and >> sends out a mail whenever a violation is detected >> NIghtly build system running find-bugs and sending a daily report >> > > >> +1 for adding find bugs to the Nightly build system >> > Point taken. But, developers should not take this for granted and commit code without making sure that it properly works. Thanks, Senaka. > > Thanks , > Charith > > >> Thanks, >> Hiranya >> >> >>> (i.e. after doing some modifications we can >>> build by turning on findbugs profile and see whether there are any >>> findbugs rule violations.). >>> >>> Here what i have in the pom file, >>> >>> <profiles> >>> <profile> >>> <id>findbugs</id> >>> <activation> >>> <property> >>> <name>findbugs</name> >>> <value>true</value> >>> </property> >>> </activation> >>> <build> >>> <plugins> >>> <plugin> >>> <groupId>org.codehaus.mojo</groupId> >>> <artifactId>findbugs-maven-plugin</artifactId> >>> <version>2.0.1</version> >>> <configuration> >>> <effort>Max</effort> >>> <threshold>Low</threshold> >>> <xmlOutput>false</xmlOutput> >>> >>> <excludeFilterFile>user-core-findbugs-excluded.xml</excludeFilterFile> >>> </configuration> >>> <executions> >>> <execution> >>> <phase>verify</phase> >>> <goals> >>> <goal>check</goal> >>> </goals> >>> </execution> >>> </executions> >>> </plugin> >>> </plugins> >>> </build> >>> </profile> >>> </profiles> >>> >>> If you have any rules which you want to ignore you can use a exclude >>> filter. For above scenario i am using "user-core-findbugs-excluded.xml" >>> exclude filter file and you can see it in [1]. So i believe same >>> procedure can be used to avoid analyzing generated code. (Until we fix >>> them) >>> >>> [1] >>> >>> https://svn.wso2.org/repos/wso2/trunk/carbon/core/org.wso2.carbon.user.core/user-core-findbugs-excluded.xml >>> >>> If we want to closely monitor rule violations we should implement svn >>> hook as mentioned in below mail. Another way to do this is to have a >>> separate findbugs profile and run it in a separate builder machine. >>> >>> Thanks >>> AmilaJ >>> >>> >>> Afkham Azeez wrote: >>> > It will be great if we can implement that. >>> > >>> > Azeez >>> > >>> > >>> > >>> > On Mon, Sep 27, 2010 at 11:06 AM, Senaka Fernando <[email protected] >>> > <mailto:[email protected]>> wrote: >>> > >>> > >>> > >>> > On Mon, Sep 27, 2010 at 10:43 AM, Afkham Azeez <[email protected] >>> > <mailto:[email protected]>> wrote: >>> > >>> > Hi Team, >>> > We have made a significant investment in fixing up our code >>> > using FindBugs. In order to maintain this, we need to run all >>> > the modified code through FindBugs before committing, >>> henceforth. >>> > >>> > >>> > Yes, +1. This should be mandatory. Azeez, btw, how about that svn >>> > post commit hook thing that we discussed? >>> > >>> > Thanks, >>> > Senaka. >>> > >>> > >>> > Thanks >>> > -- >>> > *Afkham Azeez* >>> > Senior Software Architect & Senior Manager; WSO2, Inc.; >>> > http://wso2.com, >>> > / >>> > / >>> > /Member; Apache Software Foundation; // >>> http://www.apache.org/// >>> > email: //[email protected]/ <mailto:[email protected]>/ cell: +94 77 >>> > 3320919 >>> > blog: //http://blog.afkham.org// >>> > twitter: //http://twitter.com/afkham_azeez// >>> > linked-in: //http://lk.linkedin.com/in/afkhamazeez/ >>> > / >>> > / >>> > /Lean . Enterprise . Middleware/ >>> > >>> > >>> > >>> > _______________________________________________ >>> > Stratos-dev mailing list >>> > [email protected] <mailto:[email protected]> >>> > https://wso2.org/cgi-bin/mailman/listinfo/stratos-dev >>> > >>> > >>> > >>> > >>> > -- >>> > Senaka Fernando >>> > Associate Technical Lead >>> > WSO2 Inc. >>> > E-mail: senaka AT wso2.com <http://wso2.com>; Mobile: +94 77 322 >>> 1818 >>> > >>> > http://www.wso2.com/ - "Lean . Enterprise . Middleware" >>> > >>> > >>> > >>> > >>> > -- >>> > *Afkham Azeez* >>> > Senior Software Architect & Senior Manager; WSO2, Inc.; >>> http://wso2.com, >>> > / >>> > / >>> > /Member; Apache Software Foundation; //http://www.apache.org/// >>> > email: //[email protected]/ <mailto:[email protected]>/ cell: +94 77 3320919 >>> > blog: //http://blog.afkham.org// >>> > twitter: //http://twitter.com/afkham_azeez// >>> > linked-in: //http://lk.linkedin.com/in/afkhamazeez/ >>> > / >>> > / >>> > /Lean . Enterprise . Middleware/ >>> > >>> > >>> ------------------------------------------------------------------------ >>> > >>> > _______________________________________________ >>> > Stratos-dev mailing list >>> > [email protected] >>> > https://wso2.org/cgi-bin/mailman/listinfo/stratos-dev >>> > >>> >>> >>> _______________________________________________ >>> Stratos-dev mailing list >>> [email protected] >>> https://wso2.org/cgi-bin/mailman/listinfo/stratos-dev >>> >> >> >> >> -- >> Hiranya Jayathilaka >> Senior Software Engineer; >> WSO2 Inc.; http://wso2.org >> E-mail: [email protected]; Mobile: +94 77 633 3491 >> Blog: http://techfeast-hiranya.blogspot.com >> >> _______________________________________________ >> Carbon-dev mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Senaka Fernando Associate Technical Lead WSO2 Inc. E-mail: senaka AT wso2.com; Mobile: +94 77 322 1818 http://www.wso2.com/ - "Lean . Enterprise . Middleware"
_______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
