Hi,

On Sat, Dec 18, 2010 at 7:06 PM, Indika Kumara <[email protected]> wrote:

> Indeed very interesting!! – a lot to learn from. Look like Andreas
> Veithen's code (also http core) (only from the codes I have been familiar
> with) : java doc as required + a set of suitable abstractions for modeling a
> solution in terms of abstractions.
>
>
> If I am correct, Udayanga's code is in [1], and 'Base64EncodeFunction.java'
> is not part of his code.
>
Thank you n everyone for your feedback . yes , core part for Xpath Extension
framework resides there [1]  , plus minor modifications in Synapse Xpath
Context classes, SynapseEnvironment , etc. You can find further
documentation in synapse trunk under "Synapse Extending" section as well.


>
>
> From my point of view, I feel that the ‘XpathExtensionUtil’ can be improved
> (I have not looked at it in details).
>
+1

I see that the number of arguments are higher than 3.  You may be agreed or
> not with it but please have a look at the section 'Function Arguments' in
> Clean Code, Robert C. Martin.
>
thanks for pointing this out. i'll have a look and see how the code can be
improved further... :)

Regards,
Udayanga


-- 
*Udayanga Wickramasinghe*
Software Engineer; WSO2 Inc.; http://wso2.com,
*email: **[email protected]* <[email protected]>* cell: +94 (77) 983-4365
blog: **http://udayangawiki.blogspot.com*<http://udayangawiki.blogspot.com/>
*
twitter: **http://twitter.com/udayanga_wick*<http://twitter.com/udayanga_wick>
*
*
_______________________________________________
Carbon-dev mailing list
[email protected]
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to