Hi Ranga,
First of all, Thanks a lot for the great effort you have put in to identify
these points.
On Tue, Mar 15, 2011 at 12:40 AM, Ranga Siriwardena <ra...@wso2.com> wrote:
> Hi Harshana,
>
>
>
> On Mon, Mar 14, 2011 at 11:02 PM, Harshana Martin <harsh...@wso2.com>
> wrote:
> > Hi Azeez and All,
> >
> > On Mon, Mar 14, 2011 at 8:59 PM, Afkham Azeez <az...@wso2.com> wrote:
> >>
> >> Nuwan, Harshana,
> >> Please try to fix this ASAP. It is holding back the entire team.
> >
> > When we don't have incremental build integrated, dashboard builds fine.
> When
> > we have incremental build in place it has this problem. (I just tested
> with
> > and without it).
> > When we have incremental build plugin in there, it complaints about
> > "null:org.wso2.carbon.dashboard.common:bundle:null". But after commenting
> > out the "org.wso2.carbon.dashboard.common" from the dependencies section,
> it
> > builds fine with incremental build. Here the thing is
> > same org.wso2.carbon.dashboard.common bundle is declared as a dependency
> and
> > included as in the bundles section as well ( see below)
> > <dependency>
> > <groupId>org.wso2.carbon</groupId>
> > <artifactId>org.wso2.carbon.dashboard.common</artifactId>
> > <version>3.2.0-SNAPSHOT</version>
> > </dependency>
> > and
> > <bundleDef>org.wso2.carbon:org.wso2.carbon.dashboard.common</bundleDef>.
> > When i commented the dependency section it builds fine with
> > Incremental-Build. So how should we tackle this?
>
> Yes, As you mentioned if we comment those problem making dependencies,
> features can be build successfully. And the interesting thing is even
> without having those as dependencies builder adding those dependencies in to
> the feature bundles.
>
Yes. This is because we have included them as bundlesDefs for Carbon p2
plugin. So this goes to one my original questions. Do we need a separate
Dependencies section for bundleDefs?
>
> For example, even if you commented above "org.wso2.carbon.dashboard.common"
> dependency, the output feature bundle including it as a plugin.
>
> And the other important point is we can solve the issue by using exact
> version instead of a property value inside related components as discussed
> by AmilaM.
>
> For example, with "org.wso2.carbon.dashboard.common" component we use a
> property value like bellow when defining parent.
> <parent>
>
> <groupId>org.wso2.carbon</groupId>
> <artifactId>dashboard</artifactId>
> <version>*${wso2carbon.version.dashboard}*</version>
> </parent>
>
> So instead of this property value we can exact version like bellow.
> <parent>
>
> <groupId>org.wso2.carbon</groupId>
> <artifactId>carbon-components</artifactId>
>
> <version>*3.2.0-SNAPSHOT*</version>
> </parent>
>
> So this will solve the problem in features and we don't need to comment
> dependencies here. Honestly I couldn't identify the exact reason for this :)
>
> It looks we have two possible solutions and we have to identify the proper
> solution for this problem if we are going with the plugin.
+1. Let's have a chat tomorrow
Thanks and Regards,
Harshana
>
>
>
> > For the moment I can revert the incremental build. Shall I do that?
> > @Team, Extremely sorry for the inconvenience.
> > Thanks and Regards,
> > Harshana
> >
> >>
> >> Thanks
> >> Azeez
> >>
> >> On Mon, Mar 14, 2011 at 8:22 PM, Amila Maha Arachchi <ami...@wso2.com>
> >> wrote:
> >>>
> >>> Hi Nuwan,
> >>>
> >>> On Mon, Mar 14, 2011 at 8:01 PM, Nuwan Bandara <nu...@wso2.com> wrote:
> >>>>
> >>>> Hi Amila,
> >>>>
> >>>> Anyhow will investigate more into this and will let you know.
> >>>
> >>> Yes. Your commit was done on 9th Feb and this was building fine after
> >>> that until last Friday (thats when I built this for the last time). So,
> the
> >>> version property cant be the only reason (although removing it fixes
> the
> >>> issue).
> >>>
> >>> Thanks,
> >>> AmilaM.
> >>>>
> >>>> Thanks,
> >>>> /Nuwan
> >>>>
> >>>> On Mon, Mar 14, 2011 at 7:53 PM, Nuwan Bandara <nu...@wso2.com>
> wrote:
> >>>>>
> >>>>> Hi Amila,
> >>>>>
> >>>>> On Mon, Mar 14, 2011 at 7:46 PM, Amila Maha Arachchi <
> ami...@wso2.com>
> >>>>> wrote:
> >>>>>>
> >>>>>> Hi Nuwan,
> >>>>>>
> >>>>>> Yes, theres no error when building dashboard components. But,
> >>>>>>
> >>>>>> On Mon, Mar 14, 2011 at 6:58 PM, Nuwan Bandara <nu...@wso2.com>
> wrote:
> >>>>>>>
> >>>>>>> Hi Amila,
> >>>>>>>
> >>>>>>> On Mon, Mar 14, 2011 at 6:31 PM, Amila Maha Arachchi
> >>>>>>> <ami...@wso2.com> wrote:
> >>>>>>>>
> >>>>>>>> Hi,
> >>>>>>>>
> >>>>>>>> While going through this, I came across the the commit r87172 done
> >>>>>>>> by Nuwan. According to this, version of the parent pom is defined
> as
> >>>>>>>> ${wso2carbon.version.dashboar}. But this is defined in the parent
> pom.xml.
> >>>>>>>> This is like the chicken & egg problem. I think we have to keep
> the version
> >>>>>>>> as 3.2.0-SNAPSHOT or define the variable in each pom itself.
> >>>>>>>
> >>>>>>> r87172 is committed for dashboard/components, and I think this is
> not
> >>>>>>> the same issue. However regarding the versions, I have defined a
> property
> >>>>>>> called
> >>>>>>> wso2carbon.version.dashboard in my dashboard root pom and in my
> >>>>>>> child poms I have given this property as the parent's version.
> AFAIK, this
> >>>>>>> doesnt create any cyclic issue, because at the build time, 1st of
> all the
> >>>>>>> parent pom is read by maven and the properties are taken to memory,
> and by
> >>>>>>> the time the child is build this property is there in the memory.
> So there
> >>>>>>> cant be any issue. I might be wrong here, but I did not encounter
> such issue
> >>>>>>> while building components in a clean repo.
> >>>>>>
> >>>>>> When reading the parent pom, isnt the version also needed?Because
> >>>>>> there can be more than one pom with the same name but different
> versions.
> >>>>>
> >>>>> Well a child pom can have only one parent pom I belive, and the
> parent
> >>>>> pom has the version hard-coded in this case. So I think it should be
> >>>>> alright.
> >>>>>
> >>>>>>
> >>>>>> I also don't understand the exact reason how the features get built
> >>>>>> when I replace your property with 3.2.0-SNAPSHOT.
> >>>>>
> >>>>> Wired, how ever for this particular issue we figured that its a
> result
> >>>>> of some issue in the incremental build plugin. Ranga will provide
> more
> >>>>> details.
> >>>>>
> >>>>> Regards,
> >>>>> /Nuwan
> >>>>>
> >>>>>>
> >>>>>> And, most of the poms have the parent version hardcoded (just an
> >>>>>> observation)
> >>>>>>
> >>>>>> Thanks,
> >>>>>> AmilaM.
> >>>>>>>
> >>>>>>> However there seems to be an issue in the building
> features/dashboard
> >>>>>>> Ranga is looking in to it at the moment.
> >>>>>>>
> >>>>>>> Thanks & Regards,
> >>>>>>> /Nuwan
> >>>>>>>
> >>>>>>>>
> >>>>>>>> I changed this locally and was able to get the dashboard features
> >>>>>>>> build successfully.
> >>>>>>>>
> >>>>>>>> Thanks,
> >>>>>>>> AmilaM.
> >>>>>>>>
> >>>>>>>> On Mon, Mar 14, 2011 at 3:14 PM, Supun Kamburugamuva
> >>>>>>>> <su...@wso2.com> wrote:
> >>>>>>>>>
> >>>>>>>>> FYI:
> >>>>>>>>>
> >>>>>>>>> Project ID: null:org.wso2.carbon.dashboard.common:bundle:null
> >>>>>>>>>
> >>>>>>>>> Reason: Cannot find parent: org.wso2.carbon:dashboard for
> project:
> >>>>>>>>> null:org.wso2.carbon.dashboard.common:bundle:null for project
> >>>>>>>>> null:org.wso2.carbon.dashboard.common:bundle:null
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> [INFO]
> >>>>>>>>>
> ------------------------------------------------------------------------
> >>>>>>>>> [INFO] Trace
> >>>>>>>>> org.apache.maven.lifecycle.LifecycleExecutionException: Unable to
> >>>>>>>>> get
> >>>>>>>>> dependency information: Unable to read the metadata file for
> >>>>>>>>> artifact
> >>>>>>>>> 'org.wso2.carbon:org.wso2.carbon.dashboard.common:jar': Cannot
> find
> >>>>>>>>> parent: org.wso2.carbon:dashboard for project:
> >>>>>>>>> null:org.wso2.carbon.dashboard.common:bundle:null for project
> >>>>>>>>> null:org.wso2.carbon.dashboard.common:bundle:null
> >>>>>>>>>
> >>>>>>>>>
> org.wso2.carbon:org.wso2.carbon.dashboard.common:jar:3.2.0-SNAPSHOT
> >>>>>>>>>
> >>>>>>>>> from the specified remote repositories:
> >>>>>>>>> com.springsource.repository.bundles.external
> >>>>>>>>> (http://repository.springsource.com/maven/bundles/external),
> >>>>>>>>> com.springsource.repository.bundles.release
> >>>>>>>>> (http://repository.springsource.com/maven/bundles/release),
> >>>>>>>>> wso2-maven2-snapshot-repository
> >>>>>>>>> (http://dist.wso2.org/snapshots/maven2),
> >>>>>>>>> central (http://repo1.maven.org/maven2),
> >>>>>>>>> wso2-maven2-repository (http://dist.wso2.org/maven2)
> >>>>>>>>>
> >>>>>>>>> Path to dependency:
> >>>>>>>>> 1)
> >>>>>>>>>
> org.wso2.carbon:org.wso2.carbon.dashboard.server.feature:pom:3.2.0-SNAPSHOT
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:711)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
> >>>>>>>>> at
> >>>>>>>>> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
> >>>>>>>>> at
> >>>>>>>>> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
> >>>>>>>>> at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
> >>>>>>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> >>>>>>>>> Method)
> >>>>>>>>> at
> >>>>>>>>>
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> >>>>>>>>> at
> >>>>>>>>>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> >>>>>>>>> at java.lang.reflect.Method.invoke(Method.java:597)
> >>>>>>>>> at
> >>>>>>>>>
> org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
> >>>>>>>>> at
> >>>>>>>>> org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
> >>>>>>>>> at
> >>>>>>>>>
> org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
> >>>>>>>>> at
> org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> >>>>>>>>> Caused by:
> >>>>>>>>> org.apache.maven.artifact.resolver.ArtifactResolutionException:
> >>>>>>>>> Unable to get dependency information: Unable to read the metadata
> >>>>>>>>> file
> >>>>>>>>> for artifact
> >>>>>>>>> 'org.wso2.carbon:org.wso2.carbon.dashboard.common:jar':
> >>>>>>>>> Cannot find parent: org.wso2.carbon:dashboard for project:
> >>>>>>>>> null:org.wso2.carbon.dashboard.common:bundle:null for project
> >>>>>>>>> null:org.wso2.carbon.dashboard.common:bundle:null
> >>>>>>>>>
> >>>>>>>>>
> org.wso2.carbon:org.wso2.carbon.dashboard.common:jar:3.2.0-SNAPSHOT
> >>>>>>>>>
> >>>>>>>>> from the specified remote repositories:
> >>>>>>>>> com.springsource.repository.bundles.external
> >>>>>>>>> (http://repository.springsource.com/maven/bundles/external),
> >>>>>>>>> com.springsource.repository.bundles.release
> >>>>>>>>> (http://repository.springsource.com/maven/bundles/release),
> >>>>>>>>> wso2-maven2-snapshot-repository
> >>>>>>>>> (http://dist.wso2.org/snapshots/maven2),
> >>>>>>>>> central (http://repo1.maven.org/maven2),
> >>>>>>>>> wso2-maven2-repository (http://dist.wso2.org/maven2)
> >>>>>>>>>
> >>>>>>>>> Path to dependency:
> >>>>>>>>> 1)
> >>>>>>>>>
> org.wso2.carbon:org.wso2.carbon.dashboard.server.feature:pom:3.2.0-SNAPSHOT
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.artifact.resolver.DefaultArtifactCollector.recurse(DefaultArtifactCollector.java:430)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.artifact.resolver.DefaultArtifactCollector.collect(DefaultArtifactCollector.java:74)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:316)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:304)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.plugin.DefaultPluginManager.resolveTransitiveDependencies(DefaultPluginManager.java:1499)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:442)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
> >>>>>>>>> ... 17 more
> >>>>>>>>> Caused by:
> >>>>>>>>>
> org.apache.maven.artifact.metadata.ArtifactMetadataRetrievalException:
> >>>>>>>>> Unable to read the metadata file for artifact
> >>>>>>>>> 'org.wso2.carbon:org.wso2.carbon.dashboard.common:jar': Cannot
> find
> >>>>>>>>> parent: org.wso2.carbon:dashboard for project:
> >>>>>>>>> null:org.wso2.carbon.dashboard.common:bundle:null for project
> >>>>>>>>> null:org.wso2.carbon.dashboard.common:bundle:null
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.project.artifact.MavenMetadataSource.retrieveRelocatedProject(MavenMetadataSource.java:200)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.project.artifact.MavenMetadataSource.retrieveRelocatedArtifact(MavenMetadataSource.java:94)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.artifact.resolver.DefaultArtifactCollector.recurse(DefaultArtifactCollector.java:387)
> >>>>>>>>> ... 23 more
> >>>>>>>>> Caused by: org.apache.maven.project.ProjectBuildingException:
> >>>>>>>>> Cannot
> >>>>>>>>> find parent: org.wso2.carbon:dashboard for project:
> >>>>>>>>> null:org.wso2.carbon.dashboard.common:bundle:null for project
> >>>>>>>>> null:org.wso2.carbon.dashboard.common:bundle:null
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.project.DefaultMavenProjectBuilder.assembleLineage(DefaultMavenProjectBuilder.java:1396)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.project.DefaultMavenProjectBuilder.buildInternal(DefaultMavenProjectBuilder.java:823)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.project.DefaultMavenProjectBuilder.buildFromRepository(DefaultMavenProjectBuilder.java:255)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.project.artifact.MavenMetadataSource.retrieveRelocatedProject(MavenMetadataSource.java:163)
> >>>>>>>>> ... 25 more
> >>>>>>>>> Caused by: org.apache.maven.project.ProjectBuildingException: POM
> >>>>>>>>> 'org.wso2.carbon:dashboard' not found in repository: System is
> >>>>>>>>> offline.
> >>>>>>>>>
> >>>>>>>>> org.wso2.carbon:dashboard:pom:${wso2carbon.version.dashboard}
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> for project org.wso2.carbon:dashboard
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.project.DefaultMavenProjectBuilder.findModelFromRepository(DefaultMavenProjectBuilder.java:605)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.project.DefaultMavenProjectBuilder.assembleLineage(DefaultMavenProjectBuilder.java:1392)
> >>>>>>>>> ... 28 more
> >>>>>>>>> Caused by:
> >>>>>>>>> org.apache.maven.artifact.resolver.ArtifactNotFoundException:
> >>>>>>>>> System is offline.
> >>>>>>>>>
> >>>>>>>>> org.wso2.carbon:dashboard:pom:${wso2carbon.version.dashboard}
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:203)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:90)
> >>>>>>>>> at
> >>>>>>>>>
> org.apache.maven.project.DefaultMavenProjectBuilder.findModelFromRepository(DefaultMavenProjectBuilder.java:558)
> >>>>>>>>> ... 29 more
> >>>>>>>>> [INFO]
> >>>>>>>>>
> ------------------------------------------------------------------------
> >>>>>>>>>
> >>>>>>>>> Thanks,
> >>>>>>>>> --
> >>>>>>>>> Supun Kamburugamuva
> >>>>>>>>> Technical Lead & Product Manager, WSO2 Inc.; http://wso2.com
> >>>>>>>>> Member, Apache Software Foundation; http://www.apache.org
> >>>>>>>>> WSO2 Inc.; http://wso2.org
> >>>>>>>>> E-mail: su...@wso2.com; Mobile: +94 77 431 3585
> >>>>>>>>> Blog: http://supunk.blogspot.com
> >>>>>>>>> _______________________________________________
> >>>>>>>>> Carbon-dev mailing list
> >>>>>>>>> Carbon-dev@wso2.org
> >>>>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> Thanks & Regards,
> >>>>>>>
> >>>>>>> Nuwan Bandara
> >>>>>>> Software Engineer
> >>>>>>> WSO2 Inc. | http://wso2.com
> >>>>>>> lean . enterprise . middleware
> >>>>>>>
> >>>>>>> http://www.nuwanbando.com
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Thanks & Regards,
> >>>>>
> >>>>> Nuwan Bandara
> >>>>> Software Engineer
> >>>>> WSO2 Inc. | http://wso2.com
> >>>>> lean . enterprise . middleware
> >>>>>
> >>>>> http://www.nuwanbando.com
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> Thanks & Regards,
> >>>>
> >>>> Nuwan Bandara
> >>>> Software Engineer
> >>>> WSO2 Inc. | http://wso2.com
> >>>> lean . enterprise . middleware
> >>>>
> >>>> http://www.nuwanbando.com
> >>>>
> >>>>
> >>>
> >>>
> >>> _______________________________________________
> >>> Carbon-dev mailing list
> >>> Carbon-dev@wso2.org
> >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
> >>>
> >>
> >>
> >>
> >> --
> >> Afkham Azeez
> >> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com
> ,
> >>
> >> Member; Apache Software Foundation; http://www.apache.org/
> >> email: az...@wso2.com cell: +94 77 3320919
> >> blog: http://blog.afkham.org
> >> twitter: http://twitter.com/afkham_azeez
> >> linked-in: http://lk.linkedin.com/in/afkhamazeez
> >>
> >> Lean . Enterprise . Middleware
> >>
> >> _______________________________________________
> >> Carbon-dev mailing list
> >> Carbon-dev@wso2.org
> >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
> >>
> >
> >
> >
> > --
> > Harshana Martin
> > Software Engineer
> > WSO2 Inc.
> > Web:http://wso2.com
> > http://wso2.org
> > Mobile: +94 716062650
> > Blog: http://harshana05.blogspot.com
> > Profile: https://www.google.com/profiles/harshana05
> > Twitter: http://twitter.com/harshana05
> >
> > _______________________________________________
> > Carbon-dev mailing list
> > Carbon-dev@wso2.org
> > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
> >
> >
>
>
> Thank You.
>
> --
> Ranga Siriwardena
> Software Engineer
> WSO2 Inc.
>
> Mobile: +94 779808031
> Blog: http://rangasiriwardena.blogspot.com/
>
>
>
--
Harshana Martin
Software Engineer
WSO2 Inc.
Web:http://wso2.com
http://wso2.org
Mobile: +94 716062650
Blog: http://harshana05.blogspot.com
Profile: https://www.google.com/profiles/harshana05
Twitter: http://twitter.com/harshana05
_______________________________________________
Carbon-dev mailing list
Carbon-dev@wso2.org
http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
