On Sat, May 7, 2011 at 8:32 AM, Danushka Menikkumbura <danus...@wso2.com>wrote:
> It still logs an error.
Since this is a problem with bam data publishers and currently has fixed
with setting proper tenant id please revert this change.
It is not a nice thing to catch NullPointerException and the log messages
may gone undetected.
thanks,
Amila.
>
>
> On Sat, May 7, 2011 at 8:02 AM, Amila Suriarachchi <am...@wso2.com> wrote:
>
>>
>>
>> On Sat, May 7, 2011 at 6:23 AM, Danushka Menikkumbura
>> <danus...@wso2.com>wrote:
>>
>>> Hi Amila,
>>>
>>> I think there was some miscommunication. Supun, correct me if I am wrong.
>>>
>>> Anyway I have now handled NPE in the Qpid code too.
>>>
>>
>> If the reason what I have given is correct please revert this change. This
>> may lead to such wrong invocations gone undetected.
>>
>> thanks,
>> Amila.
>>
>>
>>>
>>> But still I wonder how the Qpid call passes a -1. See the code snippet
>>> given below. This was done last week when we tested MB Stratos version.
>>>
>>> // Get tenant ID
>>> int tenantID = 0;
>>> int domainNameSeparatorIndex =
>>> username.indexOf(DOMAIN_NAME_SEPARATOR);
>>> if (-1 != domainNameSeparatorIndex) { // Service case
>>> String domainName =
>>> username.substring(domainNameSeparatorIndex + 1);
>>> tenantID =
>>> realmService.getTenantManager().getTenantId(domainName);
>>> }
>>>
>>> // Get Realm
>>> userRealm = realmService.getTenantUserRealm(tenantID);
>>>
>>> Thanks,
>>> Danushka
>>>
>>>
>>> On Sat, May 7, 2011 at 2:32 AM, Amila Jayasekara <ami...@wso2.com>wrote:
>>>
>>>> Hi Danushka,
>>>>
>>>> I did bit of debugging with the ESB pack i got from Supun and found
>>>> following.
>>>>
>>>> The tenant id passed to DefaultRealmService.getTenantUserRealm from
>>>> QpidAuthorizationPlugin.getUserRealm is -1. Thus according to
>>>> DefaultRealmService.getTenantUserRealm logic the tenant id -1 does not
>>>> have a special meaning and also it is not representing a normal
>>>> tenant. Since RealmService cannot find the appropriate tenant when
>>>> trying to retrieve Realm it gives a null pointer exception.
>>>>
>>>> I believe what you actually need is super tenant realm (Since this is
>>>> running in stand alone mode). You need to pass 0 instead of -1.
>>>>
>>>> I will add a null check to tenant, before getting RealmService; to
>>>> give a descriptive error message.
>>>>
>>>> Thanks
>>>> AmilaJ
>>>>
>>>>
>>>> On Sat, May 7, 2011 at 2:05 AM, Amila Jayasekara <ami...@wso2.com>
>>>> wrote:
>>>> > On Fri, May 6, 2011 at 8:12 PM, Danushka Menikkumbura <
>>>> danus...@wso2.com> wrote:
>>>> > AmilaJ fixed the issue in DefaultRealmService as I heard.
>>>> >
>>>> > Hi Danushka,
>>>> >
>>>> > I didnt do any modifications to DefaultRealmService with this regard.
>>>> > Similar error was reported in "[Carbon-dev] QPid exception when trying
>>>> > to invoke an admin service" mail thread.
>>>> > But later in the same thread you informed the issue was not
>>>> > reproducible with a fresh installation.
>>>> >
>>>> > Let me again investigate the pack i got from Supun.
>>>> >
>>>> > Thanks
>>>> > AmilaJ
>>>> >
>>>> >>
>>>> >> Danushka
>>>> >>
>>>> >> On Fri, May 6, 2011 at 5:18 PM, Tharindu Mathew <thari...@wso2.com>
>>>> wrote:
>>>> >>>
>>>> >>> Hi,
>>>> >>> We came up with this during smoke tests. Events published by ESB are
>>>> not
>>>> >>> being received by BAM due to this. I believe it's due to the qpid
>>>> error.
>>>> >>> Please have a look.
>>>> >>> Stacktrace:
>>>> >>> [2011-05-06 17:04:35,518] DEBUG - PublisherUtils Event payload
>>>> >>> <svrusrdata:Event
>>>> >>> xmlns:svrusrdata="
>>>> http://wso2.org/ns/2009/09/bam/server/user-defined/data
>>>> "><svrusrdata:ServerUserDefinedData><svrusrdata:ServerName>
>>>> https://10.100.0.191:9444
>>>> </svrusrdata:ServerName><svrusrdata:TenantID>0</svrusrdata:TenantID><svrusrdata:Data><svrusrdata:Key>ProxyOutMaxProcessingTime-lafProxy</svrusrdata:Key><svrusrdata:Value>1</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutAvgProcessingTime-lafProxy</svrusrdata:Key><svrusrdata:Value>0.1111111111111111</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutMinProcessingTime-lafProxy</svrusrdata:Key><svrusrdata:Value>0</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutCount-lafProxy</svrusrdata:Key><svrusrdata:Value>27</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutCumulativeCount-lafProxy</svrusrdata:Key><svrusrdata:Value>27</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutFaultCount-lafProxy</svrusrdata:Key><svrusrdata:Value>0</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutID</svrusrdata:Key><svrusrdata:Value>lafProxy</svrusrdata:Value></svrusrdata:Data></svrusrdata:ServerUserDefinedData></svrusrdata:Event>
>>>> >>> [2011-05-06 17:04:35,518] DEBUG - BAMMediationStatisticsObserver
>>>> >>> ComponentType.PROXYSERVICE <svrusrdata:Event
>>>> >>> xmlns:svrusrdata="
>>>> http://wso2.org/ns/2009/09/bam/server/user-defined/data
>>>> "><svrusrdata:ServerUserDefinedData><svrusrdata:ServerName>
>>>> https://10.100.0.191:9444
>>>> </svrusrdata:ServerName><svrusrdata:TenantID>0</svrusrdata:TenantID><svrusrdata:Data><svrusrdata:Key>ProxyOutMaxProcessingTime-lafProxy</svrusrdata:Key><svrusrdata:Value>1</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutAvgProcessingTime-lafProxy</svrusrdata:Key><svrusrdata:Value>0.1111111111111111</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutMinProcessingTime-lafProxy</svrusrdata:Key><svrusrdata:Value>0</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutCount-lafProxy</svrusrdata:Key><svrusrdata:Value>27</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutCumulativeCount-lafProxy</svrusrdata:Key><svrusrdata:Value>27</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutFaultCount-lafProxy</svrusrdata:Key><svrusrdata:Value>0</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutID</svrusrdata:Key><svrusrdata:Value>lafProxy</svrusrdata:Value></svrusrdata:Data></svrusrdata:ServerUserDefinedData></svrusrdata:Event>
>>>> >>> [2011-05-06 17:04:35,528] DEBUG - BAMMediationStatisticsObserver
>>>> Event is
>>>> >>> published<svrusrdata:Event
>>>> >>> xmlns:svrusrdata="
>>>> http://wso2.org/ns/2009/09/bam/server/user-defined/data
>>>> "><svrusrdata:ServerUserDefinedData><svrusrdata:ServerName>
>>>> https://10.100.0.191:9444
>>>> </svrusrdata:ServerName><svrusrdata:TenantID>0</svrusrdata:TenantID><svrusrdata:Data><svrusrdata:Key>ProxyOutMaxProcessingTime-lafProxy</svrusrdata:Key><svrusrdata:Value>1</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutAvgProcessingTime-lafProxy</svrusrdata:Key><svrusrdata:Value>0.1111111111111111</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutMinProcessingTime-lafProxy</svrusrdata:Key><svrusrdata:Value>0</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutCount-lafProxy</svrusrdata:Key><svrusrdata:Value>27</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutCumulativeCount-lafProxy</svrusrdata:Key><svrusrdata:Value>27</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutFaultCount-lafProxy</svrusrdata:Key><svrusrdata:Value>0</svrusrdata:Value></svrusrdata:Data><svrusrdata:Data><svrusrdata:Key>ProxyOutID</svrusrdata:Key><svrusrdata:Value>lafProxy</svrusrdata:Value></svrusrdata:Data></svrusrdata:ServerUserDefinedData></svrusrdata:Event>
>>>> >>> [2011-05-06 17:04:35,597] ERROR - DefaultRealmService
>>>> >>> java.lang.NullPointerException
>>>> >>> at
>>>> >>>
>>>> org.wso2.carbon.user.core.common.DefaultRealmService.getTenantUserRealm(DefaultRealmService.java:157)
>>>> >>> at
>>>> >>>
>>>> org.wso2.carbon.qpid.authorization.service.qpid.QpidAuthorizationPlugin.getUserRealm(QpidAuthorizationPlugin.java:184)
>>>> >>> at
>>>> >>>
>>>> org.wso2.carbon.qpid.authorization.service.qpid.QpidAuthorizationPlugin.authorise(QpidAuthorizationPlugin.java:124)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.server.security.SecurityManager$11.allowed(SecurityManager.java:390)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.server.security.SecurityManager.checkAllPlugins(SecurityManager.java:245)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.server.security.SecurityManager.authorisePublish(SecurityManager.java:386)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.server.transport.ServerSessionDelegate.messageTransfer(ServerSessionDelegate.java:307)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.server.transport.ServerSessionDelegate.messageTransfer(ServerSessionDelegate.java:96)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.MessageTransfer.dispatch(MessageTransfer.java:108)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.SessionDelegate.command(SessionDelegate.java:50)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.server.transport.ServerSessionDelegate.command(ServerSessionDelegate.java:112)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.server.transport.ServerSessionDelegate.command(ServerSessionDelegate.java:96)
>>>> >>> at org.apache.qpid.transport.Method.delegate(Method.java:159)
>>>> >>> at org.apache.qpid.transport.Session.received(Session.java:500)
>>>> >>> at
>>>> org.apache.qpid.transport.Connection.dispatch(Connection.java:404)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:64)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:40)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.MethodDelegate.messageTransfer(MethodDelegate.java:113)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.MessageTransfer.dispatch(MessageTransfer.java:108)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.ConnectionDelegate.command(ConnectionDelegate.java:54)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.ConnectionDelegate.command(ConnectionDelegate.java:40)
>>>> >>> at org.apache.qpid.transport.Method.delegate(Method.java:159)
>>>> >>> at
>>>> org.apache.qpid.transport.Connection.received(Connection.java:369)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.server.transport.ServerConnection.received(ServerConnection.java:196)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.server.transport.ServerConnection.received(ServerConnection.java:53)
>>>> >>> at
>>>> org.apache.qpid.transport.network.Assembler.emit(Assembler.java:95)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.network.Assembler.assemble(Assembler.java:217)
>>>> >>> at
>>>> org.apache.qpid.transport.network.Assembler.frame(Assembler.java:129)
>>>> >>> at org.apache.qpid.transport.network.Frame.delegate(Frame.java:133)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.network.Assembler.received(Assembler.java:100)
>>>> >>> at
>>>> org.apache.qpid.transport.network.Assembler.received(Assembler.java:42)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.network.InputHandler.next(InputHandler.java:187)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.network.InputHandler.received(InputHandler.java:103)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.network.InputHandler.received(InputHandler.java:42)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:102)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:36)
>>>> >>> at
>>>> >>>
>>>> org.apache.qpid.transport.network.mina.MINANetworkDriver.messageReceived(MINANetworkDriver.java:337)
>>>> >>> at
>>>> >>>
>>>> org.apache.mina.common.support.AbstractIoFilterChain$TailFilter.messageReceived(AbstractIoFilterChain.java:703)
>>>> >>> at
>>>> >>>
>>>> org.apache.mina.common.support.AbstractIoFilterChain.callNextMessageReceived(AbstractIoFilterChain.java:362)
>>>> >>> at
>>>> >>>
>>>> org.apache.mina.common.support.AbstractIoFilterChain.access$1200(AbstractIoFilterChain.java:54)
>>>> >>> at
>>>> >>>
>>>> org.apache.mina.common.support.AbstractIoFilterChain$EntryImpl$1.messageReceived(AbstractIoFilterChain.java:800)
>>>> >>> at
>>>> >>>
>>>> org.apache.mina.filter.executor.ExecutorFilter.processEvent(ExecutorFilter.java:243)
>>>> >>> at
>>>> >>>
>>>> org.apache.mina.filter.executor.ExecutorFilter$ProcessEventsRunnable.run(ExecutorFilter.java:305)
>>>> >>> at
>>>> >>>
>>>> edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1061)
>>>> >>> at
>>>> >>>
>>>> edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:575)
>>>> >>> at java.lang.Thread.run(Thread.java:619)
>>>> >>> [2011-05-06 17:04:35,600] WARN - QpidAuthorizationPlugin Error
>>>> while
>>>> >>> getting tenant user realm for user null!null
>>>> >>>
>>>> >>> --
>>>> >>> Regards,
>>>> >>>
>>>> >>> Tharindu
>>>> >>>
>>>> >>
>>>> >>
>>>> >> _______________________________________________
>>>> >> Carbon-dev mailing list
>>>> >> Carbon-dev@wso2.org
>>>> >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>> >>
>>>> >>
>>>> >
>>>>
>>>
>>>
>>> _______________________________________________
>>> Carbon-dev mailing list
>>> Carbon-dev@wso2.org
>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>> _______________________________________________
>> Carbon-dev mailing list
>> Carbon-dev@wso2.org
>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
> _______________________________________________
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>
_______________________________________________
Carbon-dev mailing list
Carbon-dev@wso2.org
http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
