On Mon, Jun 6, 2011 at 2:59 PM, Afkham Azeez <az...@wso2.com> wrote:

> This fix will cause a NPE when there are messages that don't get dispatched
> to services/operations.


I made a small fix to the NHTTP transport with respect to this. Azeez also
mentioned he made a minor change to Supun's original fix to make it safer.
So I guess this should be fine now. Running a full build now to verify.

Thanks,
Hiranya


>
>
> On Mon, Jun 6, 2011 at 11:50 AM, Supun Kamburugamuva <su...@wso2.com>wrote:
>
>> Committed the changes.
>>
>> Thanks,
>> Supun..
>>
>> On Mon, Jun 6, 2011 at 11:37 AM, Supun Kamburugamuva <su...@wso2.com>
>> wrote:
>> > I've fixed the issue. I'll try with AS and commit.
>> >
>> > Thanks,
>> > Supun..
>> >
>> > On Mon, Jun 6, 2011 at 11:17 AM, Hiranya Jayathilaka <hira...@wso2.com>
>> wrote:
>> >>
>> >>
>> >> On Mon, Jun 6, 2011 at 11:15 AM, Prabath Siriwardena <prab...@wso2.com
>> >
>> >> wrote:
>> >>>
>> >>> Following integration test failures reported on builder [reported
>> >>> earlier on carbon-dev].
>> >>
>> >> Yes this is due to the same error. The NPE causes the test client to
>> receive
>> >> a timeout which in turns causes an assertion to fail.
>> >> Thanks,
>> >> Hiranya
>> >>
>> >>>
>> >>> Test set: org.wso2.esb.integration.nhttp.TestRunner
>> >>>
>> >>>
>> -------------------------------------------------------------------------------
>> >>> Tests run: 4, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 333.03
>> >>> sec <<< FAILURE!
>> >>>
>> testTemplate(org.wso2.esb.integration.nhttp.HTTPHeaderManipulationTest)
>> >>>  Time elapsed: 89.577 sec  <<< FAILURE!
>> >>> junit.framework.AssertionFailedError: Error while invoking the
>> >>> HeaderManipulationProxy
>> >>>        at junit.framework.Assert.fail(Assert.java:47)
>> >>>        at
>> >>>
>> org.wso2.esb.integration.ESBIntegrationTest.handleError(ESBIntegrationTest.java:105)
>> >>>        at
>> >>>
>> org.wso2.esb.integration.nhttp.HTTPHeaderManipulationTest.successfulScenario(HTTPHeaderManipulationTest.java:56)
>> >>>        at
>> >>>
>> org.wso2.esb.integration.ESBIntegrationTest.runSuccessCase(ESBIntegrationTest.java:67)
>> >>>        at
>> >>>
>> org.wso2.carbon.integration.core.TestTemplate.testTemplate(TestTemplate.java:44)
>> >>>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> >>>        at
>> >>>
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> >>>        at
>> >>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> >>>        at java.lang.reflect.Method.invoke(Method.java:597)
>> >>>        at junit.framework.TestCase.runTest(TestCase.java:164)
>> >>>        at junit.framework.TestCase.runBare(TestCase.java:130)
>> >>>        at junit.framework.TestResult$1.protect(TestResult.java:106)
>> >>>        at junit.framework.TestResult.runProtected(TestResult.java:124)
>> >>>        at junit.framework.TestResult.run(TestResult.java:109)
>> >>>        at junit.framework.TestCase.run(TestCase.java:120)
>> >>>        at junit.framework.TestSuite.runTest(TestSuite.java:230)
>> >>>        at junit.framework.TestSuite.run(TestSuite.java:225)
>> >>>        at junit.framework.TestSuite.runTest(TestSuite.java:230)
>> >>>        at junit.framework.TestSuite.run(TestSuite.java:225)
>> >>>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> >>>        at
>> >>>
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> >>>        at
>> >>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> >>>        at java.lang.reflect.Method.invoke(Method.java:597)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
>> >>>        at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
>> >>>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> >>>        at
>> >>>
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> >>>        at
>> >>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> >>>        at java.lang.reflect.Method.invoke(Method.java:597)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
>> >>>
>> >>> testTemplate(org.wso2.esb.integration.nhttp.GETRequestQueryParamTest)
>> >>> Time elapsed: 120.821 sec  <<< FAILURE!
>> >>> junit.framework.AssertionFailedError: Error while running the GET
>> request
>> >>> test
>> >>>        at junit.framework.Assert.fail(Assert.java:47)
>> >>>        at
>> >>>
>> org.wso2.esb.integration.ESBIntegrationTest.handleError(ESBIntegrationTest.java:105)
>> >>>        at
>> >>>
>> org.wso2.esb.integration.nhttp.GETRequestQueryParamTest.successfulScenario(GETRequestQueryParamTest.java:65)
>> >>>        at
>> >>>
>> org.wso2.esb.integration.ESBIntegrationTest.runSuccessCase(ESBIntegrationTest.java:67)
>> >>>        at
>> >>>
>> org.wso2.carbon.integration.core.TestTemplate.testTemplate(TestTemplate.java:44)
>> >>>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> >>>        at
>> >>>
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> >>>        at
>> >>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> >>>        at java.lang.reflect.Method.invoke(Method.java:597)
>> >>>        at junit.framework.TestCase.runTest(TestCase.java:164)
>> >>>        at junit.framework.TestCase.runBare(TestCase.java:130)
>> >>>        at junit.framework.TestResult$1.protect(TestResult.java:106)
>> >>>        at junit.framework.TestResult.runProtected(TestResult.java:124)
>> >>>        at junit.framework.TestResult.run(TestResult.java:109)
>> >>>        at junit.framework.TestCase.run(TestCase.java:120)
>> >>>        at junit.framework.TestSuite.runTest(TestSuite.java:230)
>> >>>        at junit.framework.TestSuite.run(TestSuite.java:225)
>> >>>        at junit.framework.TestSuite.runTest(TestSuite.java:230)
>> >>>        at junit.framework.TestSuite.run(TestSuite.java:225)
>> >>>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> >>>        at
>> >>>
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> >>>        at
>> >>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> >>>        at java.lang.reflect.Method.invoke(Method.java:597)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
>> >>>        at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
>> >>>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> >>>        at
>> >>>
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> >>>        at
>> >>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> >>>        at java.lang.reflect.Method.invoke(Method.java:597)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
>> >>>
>> >>>
>> >>>
>> testTemplate(org.wso2.esb.integration.nhttp.QueryParameterManipulationTest)
>> >>>  Time elapsed: 121.721 sec  <<< FAILURE!
>> >>> junit.framework.AssertionFailedError: Error while running the GET
>> request
>> >>> test
>> >>>        at junit.framework.Assert.fail(Assert.java:47)
>> >>>        at
>> >>>
>> org.wso2.esb.integration.ESBIntegrationTest.handleError(ESBIntegrationTest.java:105)
>> >>>        at
>> >>>
>> org.wso2.esb.integration.nhttp.QueryParameterManipulationTest.successfulScenario(QueryParameterManipulationTest.java:49)
>> >>>        at
>> >>>
>> org.wso2.esb.integration.ESBIntegrationTest.runSuccessCase(ESBIntegrationTest.java:67)
>> >>>        at
>> >>>
>> org.wso2.carbon.integration.core.TestTemplate.testTemplate(TestTemplate.java:44)
>> >>>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> >>>        at
>> >>>
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> >>>        at
>> >>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> >>>        at java.lang.reflect.Method.invoke(Method.java:597)
>> >>>        at junit.framework.TestCase.runTest(TestCase.java:164)
>> >>>        at junit.framework.TestCase.runBare(TestCase.java:130)
>> >>>        at junit.framework.TestResult$1.protect(TestResult.java:106)
>> >>>        at junit.framework.TestResult.runProtected(TestResult.java:124)
>> >>>        at junit.framework.TestResult.run(TestResult.java:109)
>> >>>        at junit.framework.TestCase.run(TestCase.java:120)
>> >>>        at junit.framework.TestSuite.runTest(TestSuite.java:230)
>> >>>        at junit.framework.TestSuite.run(TestSuite.java:225)
>> >>>        at junit.framework.TestSuite.runTest(TestSuite.java:230)
>> >>>        at junit.framework.TestSuite.run(TestSuite.java:225)
>> >>>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> >>>        at
>> >>>
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> >>>        at
>> >>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> >>>        at java.lang.reflect.Method.invoke(Method.java:597)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
>> >>>        at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
>> >>>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> >>>        at
>> >>>
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> >>>        at
>> >>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> >>>        at java.lang.reflect.Method.invoke(Method.java:597)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
>> >>>        at
>> >>>
>> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
>> >>>
>> >>> Thanks & regards,
>> >>> -Prabath
>> >>>
>> >>> On Mon, Jun 6, 2011 at 11:05 AM, Charitha Kankanamge <
>> chari...@wso2.com>
>> >>> wrote:
>> >>> > Yes it is. Reported a regression L1
>> >>> > https://wso2.org/jira/browse/CARBON-10696
>> >>> >
>> >>> > /Charitha
>> >>> >
>> >>> > On Mon, Jun 6, 2011 at 10:49 AM, Hiranya Jayathilaka <
>> hira...@wso2.com>
>> >>> > wrote:
>> >>> >>
>> >>> >> ESB RC5 seems to be completely broken. I get the following when
>> trying
>> >>> >> out
>> >>> >> a basic proxy service scenario (simple pass through):
>> >>> >> [2011-06-06 10:43:35,106] ERROR - NativeWorkerPool Uncaught
>> exception
>> >>> >> java.lang.NullPointerException
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.wso2.carbon.statistics.internal.ResponseTimeCalculator.calculateResponseTimes(ResponseTimeCalculator.java:42)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.wso2.carbon.statistics.module.InOutMEPHandler.updateStatistics(InOutMEPHandler.java:103)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.wso2.carbon.statistics.module.InOutMEPHandler.invoke(InOutMEPHandler.java:87)
>> >>> >> at org.apache.axis2.engine.Phase.invokeHandler(Phase.java:340)
>> >>> >> at org.apache.axis2.engine.Phase.invoke(Phase.java:313)
>> >>> >> at org.apache.axis2.engine.AxisEngine.invoke(AxisEngine.java:262)
>> >>> >> at org.apache.axis2.engine.AxisEngine.send(AxisEngine.java:427)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.apache.synapse.core.axis2.Axis2Sender.sendBack(Axis2Sender.java:159)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.apache.synapse.core.axis2.Axis2SynapseEnvironment.send(Axis2SynapseEnvironment.java:255)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.apache.synapse.mediators.builtin.SendMediator.mediate(SendMediator.java:84)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.apache.synapse.mediators.AbstractListMediator.mediate(AbstractListMediator.java:60)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.apache.synapse.mediators.base.SequenceMediator.mediate(SequenceMediator.java:114)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.apache.synapse.core.axis2.Axis2SynapseEnvironment.injectMessage(Axis2SynapseEnvironment.java:219)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.apache.synapse.core.axis2.SynapseCallbackReceiver.handleMessage(SynapseCallbackReceiver.java:364)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.apache.synapse.core.axis2.SynapseCallbackReceiver.receive(SynapseCallbackReceiver.java:159)
>> >>> >> at org.apache.axis2.engine.AxisEngine.receive(AxisEngine.java:181)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.apache.synapse.transport.nhttp.ClientWorker.run(ClientWorker.java:273)
>> >>> >> at
>> >>> >>
>> >>> >>
>> org.apache.axis2.transport.base.threads.NativeWorkerPool$1.run(NativeWorkerPool.java:173)
>> >>> >> at
>> >>> >>
>> >>> >>
>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>> >>> >> at
>> >>> >>
>> >>> >>
>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>> >>> >> at java.lang.Thread.run(Thread.java:619)
>> >>> >>
>> >>> >> Thanks
>> >>> >> --
>> >>> >> Hiranya Jayathilaka
>> >>> >> Associate Technical Lead;
>> >>> >> WSO2 Inc.;  http://wso2.org
>> >>> >> E-mail: hira...@wso2.com;  Mobile: +94 77 633 3491
>> >>> >> Blog: http://techfeast-hiranya.blogspot.com
>> >>> >>
>> >>> >> _______________________________________________
>> >>> >> Carbon-dev mailing list
>> >>> >> Carbon-dev@wso2.org
>> >>> >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>> >>> >>
>> >>> >
>> >>> >
>> >>> > _______________________________________________
>> >>> > Carbon-dev mailing list
>> >>> > Carbon-dev@wso2.org
>> >>> > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>> >>> >
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Thanks & Regards,
>> >>> Prabath
>> >>>
>> >>> http://blog.facilelogin.com
>> >>> http://RampartFAQ.com
>> >>> _______________________________________________
>> >>> Carbon-dev mailing list
>> >>> Carbon-dev@wso2.org
>> >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>> >>
>> >>
>> >>
>> >> --
>> >> Hiranya Jayathilaka
>> >> Associate Technical Lead;
>> >> WSO2 Inc.;  http://wso2.org
>> >> E-mail: hira...@wso2.com;  Mobile: +94 77 633 3491
>> >> Blog: http://techfeast-hiranya.blogspot.com
>> >>
>> >> _______________________________________________
>> >> Carbon-dev mailing list
>> >> Carbon-dev@wso2.org
>> >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>> >>
>> >>
>> >
>> >
>> >
>> > --
>> > Supun Kamburugamuva
>> > Technical Lead &  Product Manager, WSO2 Inc.; http://wso2.com
>> > Member, Apache Software Foundation; http://www.apache.org
>> > WSO2 Inc.;  http://wso2.org
>> > E-mail: su...@wso2.com;  Mobile: +94 77 431 3585
>> > Blog: http://supunk.blogspot.com
>> >
>>
>>
>>
>> --
>> Supun Kamburugamuva
>> Technical Lead &  Product Manager, WSO2 Inc.; http://wso2.com
>> Member, Apache Software Foundation; http://www.apache.org
>> WSO2 Inc.;  http://wso2.org
>> E-mail: su...@wso2.com;  Mobile: +94 77 431 3585
>> Blog: http://supunk.blogspot.com
>> _______________________________________________
>> Carbon-dev mailing list
>> Carbon-dev@wso2.org
>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>
>
>
> --
> *Afkham Azeez*
> Director of Architecture; WSO2, Inc.; http://wso2.com
> Member; Apache Software Foundation; http://www.apache.org/
> * <http://www.apache.org/>**
> email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919
> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
> *
> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
> *
> *
> *Lean . Enterprise . Middleware*
>
>
> _______________________________________________
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


-- 
Hiranya Jayathilaka
Associate Technical Lead;
WSO2 Inc.;  http://wso2.org
E-mail: hira...@wso2.com;  Mobile: +94 77 633 3491
Blog: http://techfeast-hiranya.blogspot.com
_______________________________________________
Carbon-dev mailing list
Carbon-dev@wso2.org
http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to