On Tue, Aug 30, 2011 at 8:31 PM, Samisa Abeysinghe <sam...@wso2.com> wrote:
> > > On Tue, Aug 30, 2011 at 8:09 PM, Samisa Abeysinghe <sam...@wso2.com>wrote: > >> There are couple of things that we need to improve with code reviews: >> >> 1. We need some lead time. We should not have people come to the review >> and start learning the code or what it is about >> 2. Cut down the time to explain what the code is. Code review should focus >> on code. I see that there are training sessions going on in code reviews, >> explaining what is being done in the code, before any code is looked at. >> Rather the start should be the code. Should the explanations be required, >> then let that be secondary. >> > > We also need to > 3. Ensure that find bugs are run on the reviewed code > 4. Send in the Crucibal link for the code being reviewed the week before > 5. Send in the Sonar link for the code being reviewed the week before > I think we can properly do this from next week onwards since the notice has been already sent to the relevant people. So they have one week to prepare. > > > >> >> On Tue, Aug 30, 2011 at 6:12 PM, Afkham Azeez <az...@wso2.com> wrote: >> >>> Please update >>> https://docs.google.com/a/wso2.com/spreadsheet/ccc?key=0AggG9aSKPgHOdEU4bTdVdnBZLURrVzl4TTU5Ni1lM1E&hl=en_US#gid=1 >>> >>> >>> On Tue, Aug 30, 2011 at 3:15 PM, Afkham Azeez <az...@wso2.com> wrote: >>> >>>> You can take up an area or component which you have implemented. >>>> >>>> ---- >>>> Sent from my phone >>>> On Aug 30, 2011 1:42 PM, "Amila Jayasekara" <ami...@wso2.com> wrote: >>>> > On Tue, Aug 30, 2011 at 1:23 PM, Afkham Azeez <az...@wso2.com> wrote: >>>> >> What about Thursday or Friday? >>>> > >>>> > Hi Azeez, >>>> > >>>> > I am fine with Thursday. >>>> > Which area are we focusing on ? (I am not that familiar with single >>>> > sign on code) >>>> > >>>> > If there isnt a specific area, i would like to present some rampart >>>> > code which i am re-factoring these days. >>>> > >>>> > Thanks >>>> > AmilaJ >>>> > >>>> > >>>> >> >>>> >> ---- >>>> >> Sent from my phone >>>> >> >>>> >> On Aug 30, 2011 1:05 PM, "Amila Jayasekara" <ami...@wso2.com> wrote: >>>> >>> Hi Azeez, >>>> >>> >>>> >>> I am stuck with few support issues. Also i am working from home >>>> today. >>>> >>> Therefore i will not be able to do a code review today. >>>> >>> Thus Hasini is on vacation on this week. >>>> >>> >>>> >>> Thanks >>>> >>> AmilaJ >>>> >>> >>>> >>> >>>> >>> On Tue, Aug 30, 2011 at 9:04 AM, Afkham Azeez <az...@wso2.com> >>>> wrote: >>>> >>>> HasiniG/AmilaJ, >>>> >>>> Please prepare for a code review in place of the one which was >>>> scheduled >>>> >>>> for >>>> >>>> today. >>>> >>>> Thanks >>>> >>>> Azeez >>>> >>>> >>>> >>>> On Mon, Aug 29, 2011 at 7:21 PM, Thilina Buddhika < >>>> thili...@wso2.com> >>>> >>>> wrote: >>>> >>>>> >>>> >>>>> Hi Azeez, >>>> >>>>> I will be on vacation this week. Also there are some refactoring >>>> work >>>> >>>>> going on for SSO impl. So I would like to do it in the 3rd week of >>>> Sept. >>>> >>>>> if >>>> >>>>> possible. >>>> >>>>> Thanks, >>>> >>>>> Thilina >>>> >>>>> >>>> >>>>> On Mon, Aug 29, 2011 at 5:34 PM, Afkham Azeez <az...@wso2.com> >>>> wrote: >>>> >>>>>> >>>> >>>>>> Please note the following, and send out invitations with Crucible >>>> >>>>>> project >>>> >>>>>> link; >>>> >>>>>> Group A >>>> >>>>>> Registry Caching - Senaka >>>> >>>>>> Group B >>>> >>>>>> Distributed Transactions - Anjana >>>> >>>>>> Group C >>>> >>>>>> Single Sign-On implementation - Thilina >>>> >>>>>> Group D >>>> >>>>>> Sample Installer - Shariq >>>> >>>>>> Group E >>>> >>>>>> DeploymentSynchronizer - Hiranya >>>> >>>>>> >>>> >>>>>> Code review groups & WSO2 Technical reviews >>>> >>>>>> >>>> >>>>>> schedule: >>>> https://docs.google.com/a/wso2.com/spreadsheet/ccc?key=0AggG9aSKPgHOdEU4bTdVdnBZLURrVzl4TTU5Ni1lM1E&hl=en_US#gid=1 >>>> >>>>>> Please let me know if your name is not in any code review group. >>>> >>>>>> Thanks >>>> >>>>>> Azeez >>>> >>>>>> -- >>>> >>>>>> Afkham Azeez >>>> >>>>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>> >>>>>> Member; Apache Software Foundation; http://www.apache.org/ >>>> >>>>>> >>>> >>>>>> email: az...@wso2.com cell: +94 77 3320919 >>>> >>>>>> blog: http://blog.afkham.org >>>> >>>>>> twitter: http://twitter.com/afkham_azeez >>>> >>>>>> linked-in: http://lk.linkedin.com/in/afkhamazeez >>>> >>>>>> >>>> >>>>>> Lean . Enterprise . Middleware >>>> >>>>> >>>> >>>>> >>>> >>>>> >>>> >>>>> -- >>>> >>>>> Thilina Buddhika >>>> >>>>> Associate Technical Lead >>>> >>>>> WSO2 Inc. ; http://wso2.com >>>> >>>>> lean . enterprise . middleware >>>> >>>>> >>>> >>>>> phone : +94 77 44 88 727 >>>> >>>>> blog : http://blog.thilinamb.com >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> -- >>>> >>>> Afkham Azeez >>>> >>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>> >>>> Member; Apache Software Foundation; http://www.apache.org/ >>>> >>>> >>>> >>>> email: az...@wso2.com cell: +94 77 3320919 >>>> >>>> blog: http://blog.afkham.org >>>> >>>> twitter: http://twitter.com/afkham_azeez >>>> >>>> linked-in: http://lk.linkedin.com/in/afkhamazeez >>>> >>>> >>>> >>>> Lean . Enterprise . Middleware >>>> >>>> >>>> >> >>>> >>> >>> >>> >>> -- >>> *Afkham Azeez* >>> Director of Architecture; WSO2, Inc.; http://wso2.com >>> Member; Apache Software Foundation; http://www.apache.org/ >>> * <http://www.apache.org/>** >>> email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 >>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>> * >>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>> * >>> * >>> *Lean . Enterprise . Middleware* >>> >>> >>> _______________________________________________ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> > > _______________________________________________ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- *Afkham Azeez* Director of Architecture; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ * <http://www.apache.org/>** email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 blog: **http://blog.afkham.org* <http://blog.afkham.org>* twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> * linked-in: **http://lk.linkedin.com/in/afkhamazeez* * * *Lean . Enterprise . Middleware*
_______________________________________________ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
