Were the review recommendations implemented ?
---- Sent from my phone On Aug 31, 2011 10:59 AM, "Amila Maha Arachchi" <ami...@wso2.com> wrote: > On Wed, Aug 31, 2011 at 10:53 AM, Afkham Azeez <az...@wso2.com> wrote: > >> Where are the crucible notes? Better have an architecture review as well. >> > +1 > > Crucible link https://wso2.org/crucible/cru/COMPONENT-54 > >> ---- >> Sent from my phone >> On Aug 31, 2011 10:28 AM, "Amila Maha Arachchi" <ami...@wso2.com> wrote: >> > On Wed, Aug 31, 2011 at 10:11 AM, Afkham Azeez <az...@wso2.com> wrote: >> > >> >> >> >> >> >> On Wed, Aug 31, 2011 at 9:51 AM, Amila Maha Arachchi <ami...@wso2.com >> >wrote: >> >> >> >>> >> >>> >> >>> On Tue, Aug 30, 2011 at 9:02 AM, Afkham Azeez <az...@wso2.com> wrote: >> >>> >> >>>> Please organize the following reviews. >> >>>> >> >>>> Group A >> >>>> BAM Event Receiver - Tharindu >> >>>> >> >>>> Group B >> >>>> Gadget Repository - Nuwan >> >>>> >> >>>> Group C >> >>>> Authenticator Framework - Thilina >> >>>> >> >>>> Group D >> >>>> Registry Indexing - Janaka >> >>>> >> >>>> Group E >> >>>> Metering - AmilaM >> >>>> >> >>> >> >>> Billing code needs lot of improvements. I am on support until next >> >>> Tuesday. I'll try my best to do the improvements after that and >> present. If >> >>> not I would like to request for one more week to do the refactoring. >> >>> >> >>> >> >> How come the billing code that has been in development since last >> December >> >> suddenly need a "lot" of improvement? How did you suddenly come to >> realize >> >> this? What are these improvements? I'd suggest that you just present the >> >> code as it is for the review. If you remember, this review was scheduled >> 1-2 >> >> weeks before the StratosLive launch and got delayed because of the >> release. >> >> I believe there was ample time to rectify the code. >> >> >> > >> > Not suddenly. It was in the card for sometime. Although I started working >> on >> > it since February, my initial target was to get it working. I had to know >> > the code. >> > >> > This review was done on the scheduled date. You missed it because you >> were >> > sick IIRC. >> > >> > My concern is, the code needs design level changes. But I couldn't do >> them >> > yet. Anyway, I'll present it as it is. >> > >> >> >> >> AmilaM. >> >>> >> >>>> >> >>>> -- >> >>>> *Afkham Azeez* >> >>>> Director of Architecture; WSO2, Inc.; http://wso2.com >> >>>> Member; Apache Software Foundation; http://www.apache.org/ >> >>>> * <http://www.apache.org/>** >> >>>> email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 >> >>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> >>>> twitter: **http://twitter.com/afkham_azeez*< >> http://twitter.com/afkham_azeez> >> >> >>>> * >> >>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> >>>> * >> >>>> * >> >>>> *Lean . Enterprise . Middleware* >> >>>> >> >>>> >> >>> >> >> >> >> >> >> -- >> >> *Afkham Azeez* >> >> Director of Architecture; WSO2, Inc.; http://wso2.com >> >> Member; Apache Software Foundation; http://www.apache.org/ >> >> * <http://www.apache.org/>** >> >> email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 >> >> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> >> twitter: **http://twitter.com/afkham_azeez*< >> http://twitter.com/afkham_azeez> >> >> >> * >> >> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> >> * >> >> * >> >> *Lean . Enterprise . Middleware* >> >> >> >> >>
_______________________________________________ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
