Hi all, Code review notes:
1. Current implementation of SQS(message-box) does not use JMS connection reuse. Instead, It creates queue connections(tcp connections) per message. The reason behind this is to handle visibility timeout using JMS transaction CLIENT_ACKNOWLEDGE mode. When a message is received, the queue connection is created and session created with CLIENT_ACKNOWLEDGE enabled. If the user does not delete the received message, the session is closed without acknowledge. As a result the received message will be available or visible to other users to receive again. If the user delete the message after receiving it, message is acknowledged. If we acknowledge a message in the middle of the queue, the messages up-to that message also acknowledged. This causes to use per connection per message. Action item: There was an implementation to cache connection, and it was removed due to not working properly with multiple receivers. This should be fixed and tested. And look for other alternative to implement above use case. 2. The behavior of some JMS API calls is different with different providers, ex. create persistent queues, queue receiver receive methods. So add comments on such methods used so that it can be identified fast. 3. Add error logs before throwing exceptions. After two weeks, these improvements will be reviewed again. If I have missed anything, please add comments. Thank you. On Tue, Oct 4, 2011 at 10:27 AM, Nuwan Bandara <nu...@wso2.com> wrote: > GROUP B, Reminder !!! > > On Tue, Oct 4, 2011 at 10:02 AM, Shammi Jayasinghe <sha...@wso2.com>wrote: > >> This event has been changed. >> more details >> »<https://www.google.com/calendar/event?action=VIEW&eid=MThraHVoMG5icGNyMDNuMHRwNnU3YzRuMjAgbnV3YW5Ad3NvMi5jb20&tok=MTUjc2hhbW1pQHdzbzIuY29tOWI0MzU0MjhhNjBiY2IwMDg2NDE4Y2JiY2FkODQ2ZmRmZjQwMWM1MA&ctz=Asia%2FColombo&hl=en> >> [Code Review] [Group B] Message box core - connection reuse >> *Changed: *crcuible link : >> https://wso2.org/crucible/cru/COMPONENT-63<http://www.google.com/url?q=https%3A%2F%2Fwso2.org%2Fcrucible%2Fcru%2FCOMPONENT-63&ust=1317709922170000&usg=AFQjCNFMgu4Hh2Xo9i91MU9Kcyq0HT7Oew> >> *When* >> Tue Oct 4 10:30am – 11:30am Colombo >> *Where* >> #59 - Board Room (map<http://maps.google.lk/maps?q=%2359+-+Board+Room&hl=en> >> ) >> *Calendar* >> nu...@wso2.com >> *Who* >> • >> sha...@wso2.com - organizer >> • >> Chamara Ariyarathne >> • >> Achala Aponso >> • >> Deependra Ariyadewa >> • >> Dimuthu Leelarathne >> • >> Manjula Rathnayake >> • >> Nuwan Bandara >> • >> carbon-dev@wso2.org >> • >> Krishantha Samaraweera >> • >> Nuwan Wimalasekara >> • >> Sanjeewa Malalgoda >> • >> Anjana Fernando >> • >> Nandika Jayawardana >> • >> Ajith Vitharana >> • >> Thilini Ishaka >> • >> Jasintha Dasanayake >> >> Going? >> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=MThraHVoMG5icGNyMDNuMHRwNnU3YzRuMjAgbnV3YW5Ad3NvMi5jb20&rst=1&tok=MTUjc2hhbW1pQHdzbzIuY29tOWI0MzU0MjhhNjBiY2IwMDg2NDE4Y2JiY2FkODQ2ZmRmZjQwMWM1MA&ctz=Asia%2FColombo&hl=en>- >> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=MThraHVoMG5icGNyMDNuMHRwNnU3YzRuMjAgbnV3YW5Ad3NvMi5jb20&rst=3&tok=MTUjc2hhbW1pQHdzbzIuY29tOWI0MzU0MjhhNjBiY2IwMDg2NDE4Y2JiY2FkODQ2ZmRmZjQwMWM1MA&ctz=Asia%2FColombo&hl=en>- >> No<https://www.google.com/calendar/event?action=RESPOND&eid=MThraHVoMG5icGNyMDNuMHRwNnU3YzRuMjAgbnV3YW5Ad3NvMi5jb20&rst=2&tok=MTUjc2hhbW1pQHdzbzIuY29tOWI0MzU0MjhhNjBiY2IwMDg2NDE4Y2JiY2FkODQ2ZmRmZjQwMWM1MA&ctz=Asia%2FColombo&hl=en> >> * **more options >> »<https://www.google.com/calendar/event?action=VIEW&eid=MThraHVoMG5icGNyMDNuMHRwNnU3YzRuMjAgbnV3YW5Ad3NvMi5jb20&tok=MTUjc2hhbW1pQHdzbzIuY29tOWI0MzU0MjhhNjBiY2IwMDg2NDE4Y2JiY2FkODQ2ZmRmZjQwMWM1MA&ctz=Asia%2FColombo&hl=en> >> >> Invitation from Google Calendar <https://www.google.com/calendar/> >> >> You are receiving this email at the account nu...@wso2.com because you >> are subscribed for updated invitations on calendar nu...@wso2.com. >> >> To stop receiving these notifications, please log in to >> https://www.google.com/calendar/ and change your notification settings >> for this calendar. >> > > > > -- > *Thanks & Regards, > > Nuwan Bandara > Senior Software Engineer > WSO2 Inc. | http://wso2.com > lean . enterprise . middleware > > http://nuwan.bandara.co > * > <http://www.nuwanbando.com/> > -- Manjula Rathnayaka Software Engineer WSO2, Inc. Mobile:+94 77 743 1987
_______________________________________________ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
