On Mon, Nov 7, 2011 at 5:22 PM, Samisa Abeysinghe <sam...@wso2.com> wrote:

> Well, why not pick the method of upload based on the file extension,
> rather than disabling zip with file? What you have proposed is
> more developer friendly. What I am proposing is more user friendly :)


Got your point.
Updated the JIRA(https://wso2.org/jira/browse/CARBON-11484) according to
the most user friendly way. :)



>
>
> On Mon, Nov 7, 2011 at 4:44 PM, Ranga Siriwardena <ra...@wso2.com> wrote:
>
>> Hi Samisa,
>>
>> On Sat, Nov 5, 2011 at 12:50 PM, Samisa Abeysinghe <sam...@wso2.com>wrote:
>>
>>> I tried again both with my zip file and the zip that you sent. And
>>> neither work. For both of them I get the following error on console when I
>>> try to access the gadget source:
>>>
>>> 011-11-05 12:42:46,365] ERROR
>>> {org.apache.axis2.transport.http.CommonsHTTPTransportSender} -  Invalid
>>> white space character (0x3) in text to output
>>> g.apache.axis2.AxisFault: Invalid white space character (0x3) in text to
>>> output
>>>       at org.apache.axis2.AxisFault.makeFault(AxisFault.java:430)
>>>       at
>>> org.apache.axis2.transport.http.SOAPMessageFormatter.writeTo(SOAPMessageFormatter.java:78)
>>>       at
>>> org.apache.axis2.transport.http.CommonsHTTPTransportSender.sendUsingOutputStream(CommonsHTTPTransportSender.java:409)
>>>       at
>>> org.apache.axis2.transport.http.CommonsHTTPTransportSender.invoke(CommonsHTTPTransportSender.java:286)
>>>       at org.apache.axis2.engine.AxisEngine.send(AxisEngine.java:443)
>>>       at
>>> org.apache.axis2.receivers.AbstractInOutMessageReceiver.invokeBusinessLogic(AbstractInOutMessageReceiver.java:43)
>>>       at
>>> org.apache.axis2.receivers.AbstractMessageReceiver.receive(AbstractMessageReceiver.java:110)
>>>       at org.apache.axis2.engine.AxisEngine.receive(AxisEngine.java:181)
>>>       at
>>> org.apache.axis2.transport.http.HTTPTransportUtils.processHTTPPostRequest(HTTPTransportUtils.java:172)
>>>       at
>>> org.apache.axis2.transport.http.AxisServlet.doPost(AxisServlet.java:146)
>>>       at
>>> org.wso2.carbon.core.transports.CarbonServlet.doPost(CarbonServlet.java:199)
>>>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:641)
>>>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
>>>       at
>>> org.eclipse.equinox.http.servlet.internal.ServletRegistration.handleRequest(ServletRegistration.java:90)
>>>       at
>>> org.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:111)
>>>       at
>>> org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(ProxyServlet.java:67)
>>>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
>>>       at
>>> org.wso2.carbon.bridge.BridgeServlet.service(BridgeServlet.java:164)
>>>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
>>>       at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304)
>>>       at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
>>>       at
>>> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:240)
>>>       at
>>> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:164)
>>>       at
>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:462)
>>>       at
>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:164)
>>>       at
>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
>>>       at
>>> org.wso2.carbon.server.CarbonStuckThreadDetectionValve.invoke(CarbonStuckThreadDetectionValve.java:154)
>>>       at
>>> org.wso2.carbon.server.TomcatServer$1.invoke(TomcatServer.java:254)
>>>       at
>>> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:563)
>>>       at
>>> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
>>>       at
>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:399)
>>>       at
>>> org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:396)
>>>       at
>>> org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:356)
>>>       at
>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1534)
>>>       at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>>>       at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>>>       at java.lang.Thread.run(Thread.java:662)
>>> used by: com.ctc.wstx.exc.WstxIOException: Invalid white space character
>>> (0x3) in text to output
>>>       at
>>> com.ctc.wstx.sw.BaseStreamWriter.writeCharacters(BaseStreamWriter.java:511)
>>>       at
>>> org.apache.axiom.util.stax.wrapper.XMLStreamWriterWrapper.writeCharacters(XMLStreamWriterWrapper.java:100)
>>>       at
>>> org.apache.axiom.om.impl.MTOMXMLStreamWriter.writeCharacters(MTOMXMLStreamWriter.java:289)
>>>       at
>>> org.apache.axiom.om.impl.llom.OMTextImpl.writeOutput(OMTextImpl.java:250)
>>>       at
>>> org.apache.axiom.om.impl.llom.OMTextImpl.internalSerialize(OMTextImpl.java:405)
>>>       at
>>> org.apache.axiom.om.impl.util.OMSerializerUtil.serializeChildren(OMSerializerUtil.java:563)
>>>       at
>>> org.apache.axiom.om.impl.llom.OMElementImpl.internalSerialize(OMElementImpl.java:875)
>>>       at
>>> org.apache.axiom.om.impl.util.OMSerializerUtil.serializeChildren(OMSerializerUtil.java:563)
>>>       at
>>> org.apache.axiom.om.impl.llom.OMElementImpl.internalSerialize(OMElementImpl.java:875)
>>>       at
>>> org.apache.axiom.om.impl.util.OMSerializerUtil.serializeChildren(OMSerializerUtil.java:563)
>>>       at
>>> org.apache.axiom.om.impl.llom.OMElementImpl.internalSerialize(OMElementImpl.java:875)
>>>       at
>>> org.apache.axiom.soap.impl.llom.SOAPEnvelopeImpl.serializeInternally(SOAPEnvelopeImpl.java:283)
>>>       at
>>> org.apache.axiom.soap.impl.llom.SOAPEnvelopeImpl.internalSerialize(SOAPEnvelopeImpl.java:245)
>>>       at
>>> org.apache.axiom.om.impl.llom.OMSerializableImpl.serializeAndConsume(OMSerializableImpl.java:193)
>>>       at
>>> org.apache.axis2.transport.http.SOAPMessageFormatter.writeTo(SOAPMessageFormatter.java:74)
>>>       ... 35 more
>>> used by: java.io.IOException: Invalid white space character (0x3) in
>>> text to output
>>>       at com.ctc.wstx.sw.XmlWriter.throwInvalidChar(XmlWriter.java:545)
>>>       at
>>> com.ctc.wstx.sw.BufferingXmlWriter.writeCharacters(BufferingXmlWriter.java:531)
>>>       at
>>> com.ctc.wstx.sw.BaseStreamWriter.writeCharacters(BaseStreamWriter.java:509)
>>>       ... 49 more
>>>
>>>
>> I was able reproduce the same error when I upload the zip file with
>> "Gadget Repository > Add New Gadget > Add Gadget Using > File Path". And
>> that is actually not the correct way of adding a zipped gadget. But the UI
>> allowed to add, zip file or any other file with "Add Gadget Using > File
>> Path" option. I have created a JIRA[1] to restrict this only to XML files,
>> so user will not face such an misleading situations. I guess you also
>> encountered the same issue.
>>
>> The correct way of uploading a zip file is adding gadget with  "Gadget
>> Repository > Add New Gadget > Add Gadget Using > Zip File Path"  (Need to
>> select Zipped File Path option from the drop down menu). That will solve
>> the problem.
>>
>> [1] https://wso2.org/jira/browse/CARBON-11484
>>
>>
>>
>>> On Fri, Nov 4, 2011 at 8:23 AM, Samisa Abeysinghe <sam...@wso2.com>wrote:
>>>
>>>>
>>>>
>>>> On Fri, Nov 4, 2011 at 8:17 AM, Samisa Abeysinghe <sam...@wso2.com>wrote:
>>>>
>>>>> I am in the middle of trying out some gadgets. I will try the zip
>>>>> again later.
>>>>>
>>>>> For sure, it did not work in my first attempt.
>>>>>
>>>>
>>>> And I meant to say, since it did not work, I went ahead with the manual
>>>> resource upload path, and now the stuff are working with the setup. I have
>>>> to revert back to try the zip again.
>>>>
>>>> I may try the zip you sent later.
>>>>
>>>>
>>>>>
>>>>> On Thu, Nov 3, 2011 at 1:22 PM, Ranga Siriwardena <ra...@wso2.com>wrote:
>>>>>
>>>>>> Hi Samisa,
>>>>>>
>>>>>> On Thu, Nov 3, 2011 at 12:49 PM, Samisa Abeysinghe 
>>>>>> <sam...@wso2.com>wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Nov 3, 2011 at 12:44 PM, Lalaji Sureshika 
>>>>>>> <lal...@wso2.com>wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> On Thu, Nov 3, 2011 at 11:40 AM, Samisa Abeysinghe <sam...@wso2.com
>>>>>>>> > wrote:
>>>>>>>>
>>>>>>>>> I have the same format inside the zip, except that, I have js
>>>>>>>>> files inside a folder called js.
>>>>>>>>>
>>>>>>>>> Does having sub-folders work? if not, then it is a bug - as having
>>>>>>>>> scripts in a sub folder is std practice.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Uploading gadget zip files with having sub folders is working.I
>>>>>>>> tested this in SLive dev environment now and it works.My gadget sample
>>>>>>>> contains gadget.xml file+thumbnail folder[with images] .
>>>>>>>>
>>>>>>>
>>>>>>> Then this must be  Windows bug. It is not working on my local setup.
>>>>>>> I am using GS product, not the cloud.
>>>>>>>
>>>>>>
>>>>>>
>>>>>> You can upload any gadget with all the gadget related resources
>>>>>> inside a zip file. That zip file should contain a gadget.xml. And also 
>>>>>> that
>>>>>> zip file can have any resource (JS, CSS, images, Gadget Thumbnail etc..).
>>>>>> It is completely OK, to store those resources inside separate folders.
>>>>>> Those resources will be stored inside registry according to the same
>>>>>> directory structure we defined in the ziped file.
>>>>>>
>>>>>> So the content of ziped file should have structure like bellow.
>>>>>>
>>>>>>    - gadget.xml (Compulsory)
>>>>>>    - thumb (Folder which contains thumbnail for this gadget)
>>>>>>    - anyFolder(Which contains any resource related to the gadget)
>>>>>>
>>>>>>
>>>>>> I Just tried this on windows with GS 1.4.2. And it worked without any
>>>>>> issue. Attached the sample JiraGadget which I used to test this.
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> Thanks;
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Thu, Nov 3, 2011 at 12:36 PM, Yumani Ranaweera <yum...@wso2.com
>>>>>>>>> > wrote:
>>>>>>>>>
>>>>>>>>>> I think bundling everything in a .zip file and uploading to the
>>>>>>>>>> repository is the right way. Ranga\Lalaji please correct me if 
>>>>>>>>>> there's a
>>>>>>>>>> better way.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>>> I tried uploading a zip content just now with the attached files
>>>>>>>>>> and it worked.
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> Yumani
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Thu, Nov 3, 2011 at 12:23 PM, Samisa Abeysinghe <
>>>>>>>>>> sam...@wso2.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> And I have to add gadget and JS used by gadget separately, and
>>>>>>>>>>> manually using registry browser :(
>>>>>>>>>>>
>>>>>>>>>>> I am using 3 JS files in my gaget and I have to use 4 uploads to
>>>>>>>>>>> upload content for one gadget - am I doing this right? Is there a 
>>>>>>>>>>> better
>>>>>>>>>>> way?
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> On Thu, Nov 3, 2011 at 12:14 PM, Samisa Abeysinghe <
>>>>>>>>>>> sam...@wso2.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> What should be the content of the zip? Just the zip
>>>>>>>>>>>> of gadget XML?
>>>>>>>>>>>>
>>>>>>>>>>>> I ziped up the gadget and JS and it seems not working :( I
>>>>>>>>>>>> assumed it to expect it to be a zip of the gaget package.
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks,
>>>>>>>>>>>> Samisa...
>>>>>>>>>>>>
>>>>>>>>>>>> Samisa Abeysinghe
>>>>>>>>>>>> VP Engineering
>>>>>>>>>>>> WSO2 Inc.
>>>>>>>>>>>> http://wso2.com
>>>>>>>>>>>> http://wso2.org
>>>>>>>>>>>>
>>>>>>>>>>>>  Thanks,
>>>>>>>>>>> Samisa...
>>>>>>>>>>>
>>>>>>>>>>> Samisa Abeysinghe
>>>>>>>>>>> VP Engineering
>>>>>>>>>>> WSO2 Inc.
>>>>>>>>>>> http://wso2.com
>>>>>>>>>>> http://wso2.org
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> _______________________________________________
>>>>>>>>>>> Carbon-dev mailing list
>>>>>>>>>>> Carbon-dev@wso2.org
>>>>>>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Yumani Ranaweera
>>>>>>>>>> WSO2, Inc. - http://wso2.org
>>>>>>>>>> Email : yum...@wso2.com
>>>>>>>>>> Cell    : +94 077 7795242
>>>>>>>>>> Blog   : http://yumani.blogspot.com/
>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> Carbon-dev mailing list
>>>>>>>>>> Carbon-dev@wso2.org
>>>>>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>> Samisa...
>>>>>>>>>
>>>>>>>>> Samisa Abeysinghe
>>>>>>>>> VP Engineering
>>>>>>>>> WSO2 Inc.
>>>>>>>>> http://wso2.com
>>>>>>>>> http://wso2.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> Carbon-dev mailing list
>>>>>>>>> Carbon-dev@wso2.org
>>>>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Lalaji Sureshika
>>>>>>>>
>>>>>>>> Software Engineer
>>>>>>>> WSO2 Inc.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> Carbon-dev mailing list
>>>>>>>> Carbon-dev@wso2.org
>>>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>> Samisa...
>>>>>>>
>>>>>>> Samisa Abeysinghe
>>>>>>> VP Engineering
>>>>>>> WSO2 Inc.
>>>>>>> http://wso2.com
>>>>>>> http://wso2.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Carbon-dev mailing list
>>>>>>> Carbon-dev@wso2.org
>>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Ranga Siriwardena
>>>>>> Software Engineer
>>>>>> WSO2 Inc.
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Carbon-dev mailing list
>>>>>> Carbon-dev@wso2.org
>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>>>
>>>>>> Thanks,
>>>>> Samisa...
>>>>>
>>>>> Samisa Abeysinghe
>>>>> VP Engineering
>>>>> WSO2 Inc.
>>>>> http://wso2.com
>>>>> http://wso2.org
>>>>>
>>>>>
>>>>>  Thanks,
>>>> Samisa...
>>>>
>>>> Samisa Abeysinghe
>>>> VP Engineering
>>>> WSO2 Inc.
>>>> http://wso2.com
>>>> http://wso2.org
>>>>
>>>>
>>>>  Thanks,
>>> Samisa...
>>>
>>> Samisa Abeysinghe
>>> VP Engineering
>>> WSO2 Inc.
>>> http://wso2.com
>>> http://wso2.org
>>>
>>>
>>>
>>> _______________________________________________
>>> Carbon-dev mailing list
>>> Carbon-dev@wso2.org
>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>> Thanks.
>> Ranga.
>>
>> --
>> Ranga Siriwardena
>> Software Engineer
>> WSO2 Inc.
>>
>>
>> _______________________________________________
>> Carbon-dev mailing list
>> Carbon-dev@wso2.org
>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>> Thanks,
> Samisa...
>
> Samisa Abeysinghe
> VP Engineering
> WSO2 Inc.
> http://wso2.com
> http://wso2.org
>
>
>
> _______________________________________________
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>

Thanks.
Ranga.
-- 
Ranga Siriwardena
Software Engineer
WSO2 Inc.
_______________________________________________
Carbon-dev mailing list
Carbon-dev@wso2.org
http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to