Hi Robert,

Just committed the user_roles List 2 from GJ - SVN 6790.
In SVN 6789, the $_a_1_laball permission was fixed.

Just tested SVN 6790 fresh install - works well.

Regards,
Ap.Muthu


> Hi Muthu,
>
> Sorry, I am out of office these days - client calling ;-) More and less
> present after Monday to continue.
>
> But my idea would be to place suitable records in lang_*_access.php.
> Better sooner than later we should focus the whole ACL setting into a
> better work flow what would make it more easy to maintain and to
> understand - and used in all modules in the same way.
>
> Just my 2 pence.
>
> I will go after Monday through all files again and look for non declared
> variables. There are still some around the files, well hidden by some
> includes what might be present, but its not. When we would have it all
> in a way that it is working error free, I would suggest to freeze then
> this version and would like to think to release it. Gjergj, what do you
> think about this idea?
>
> Then we should go in the next version to review all these strange
> settings we found now in that review now.
>
> Robert
>
>
> Am Freitag, den 24.09.2010, 21:23 +0530 schrieb Ap.Muthu:
>> Thanks GJ for the short explanation of the _a2_* permissions possible
>> historical significance.
>>
>> In case the "_a_1_laball" permission set is being used by any proprietary
>> scripts exclusively (not present in the trunk), it may have got into your
>> system's role permissions.
>>
>> Please let me know if we can delete it from the
>> "global_conf/areas_allow.php" and "global_conf/areas.php"
>>     or
>> do we place a language variable suitably populated in the
>> "language/en/lang_en_access.php" file?
>>
>> The latter will be the preferred path if the permission "_a_1_laball" was
>> being used extensively although in a proprietary manner.
>>
>> Regards,
>> Ap.Muthu
>>
>>
>>
>> >  hi Muthu,
>> >
>> > short explanation - maybe there some c2x history here of which i'm
>> > unaware - there are two level
>> > modules in c2x, the first one is the lab, nursing, OR and such. the
>> > second level is
>> > hr, billing, address management and such.
>> > furthermore, there are modules meant to be read only by some possible
>> > web based
>> > patient, hence the _a2_*
>> >
>> > you can see more about it if you look for second level access.
>> >
>> > regarding the permission present only in the sw language, i think it's 
>> > a
>> > leftover from
>> > care2watu.
>> >
>> > now regarding :
>> >
>> >   'lab_r'=>array('_a_1_labresultswrite', '_a_2_labresultsread'),
>> >   'lab_w'=>array('_a_1_labresultswrite'),
>> >   'lab_all'=>array('_a_1_laball'),
>> >
>> > i should test it before being able to respond.
>> > you have to remember that on c2x there was a lot of code submitted
>> > by non programmers..
>> >
>> >
>> > gj.
>> >
>> >
>> > On 2010-09-24 3:37.MD, Ap.Muthu wrote:
>> >> A total of 382 permissions across 35 sample roles in GJ list 2 were
>> >> analysed to provide 45 unique permissions.
>> >>
>> >> Will someone please explain what the "_a_1_*" and "_a_2_*" permissions
>> >> mean?
>> >>
>> >> File: global_conf/areas_allow.php
>> >> Lines 27-31:
>> >>    'lab_r'=>array('_a_1_labresultswrite', '_a_2_labresultsread'),
>> >>
>> >>    'lab_w'=>array('_a_1_labresultswrite'),
>> >>
>> >>    'lab_all'=>array('_a_1_laball'),
>> >>
>> >> There seems to be an error here. The _a_1_laball access role should be
>> >> allowed access to files requiring lab_r and lab_w permissions as well,
>> >> just as the _a_1_labresultswrite role has access to files requiring 
>> >> lab_r
>> >> permission.
>> >>
>> >> Hence the above should be:
>> >>    'lab_r'=>array('_a_1_laball', '_a_1_labresultswrite',
>> >> '_a_2_labresultsread'),
>> >>
>> >>    'lab_w'=>array('_a_1_laball', '_a_1_labresultswrite'),
>> >>
>> >>    'lab_all'=>array('_a_1_laball'),
>> >>
>> >> File: global_conf/areas.php
>> >> Line: 28
>> >>    '_a_1_laball' =>  $_a_1_lab_admin,
>> >> The above variable $_a_1_lab_admin  (and _a_1_lab_admin) is not found
>> >> anywhere at all - not in *.php and not in *.tpl.
>> >> Even if we change the variable to $_a_1_laball  or $_a_1_lab_all even
>> >> that permission is not used by any file and is not present in any
>> >> language file other than en and sw! The situation is the same for
>> >> variables:
>> >> $_a_0_laball, $_a_2_laball, $_a_0_lab_all, $_a_2_lab_all
>> >>
>> >> Hence can we delete the line 28 in file global_conf/areas.php and 
>> >> delete
>> >> the line 31 in file global_conf/areas_allow.php leaving the rest
>> >> unchanged?
>> >>
>> >> The said permission _a_1_laball is used in GJ's second list for the
>> >> Doctor_Lab role and the Head_Medical_Commission role. Both roles have
>> >> permission _a_1_labresultswrite and the latter has the permission
>> >> _a_2_labresultsread as well.
>> >>
>> >> Regards,
>> >> Ap.Muthu



------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Care2002-developers mailing list
Care2002-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/care2002-developers

Reply via email to