[ https://forge.continuent.org/jira/browse/CAROB-91?page=all ]
     
Marc Herbert resolved CAROB-91:
-------------------------------

    Resolution: Fixed

This is now implemented:
make CXXFLAGS="-Wall -O2"

The environnement variable syntax is not implemented because it is not 
recommended by "info make"
(and probably more complex to implement). The use of environnement variables 
lacks transparency,
it makes invocations subtly different from one user to the other and generally 
debugging hard.

The command line arguments syntax above should be enough, since you can always 
hardcode this:
  make CXXFLAGS=${CXXFLAGS}
in case you really want to go the environnement variable way.

Please close in case you are satisfied with the fix.

Not 100% sure which LDFLAGS are optional, feel free to move them between the 
"optional" and "mandatory" sections.



> Makefile overrides CXXFLAGS and LDFLAGS
> ---------------------------------------
>
>          Key: CAROB-91
>          URL: https://forge.continuent.org/jira/browse/CAROB-91
>      Project: Carob
>         Type: Bug
>   Components: C++ API
>     Versions: 0.5
>     Reporter: Simon Csaba Endre
>     Assignee: Marc Herbert
>     Priority: Minor
>      Fix For: 1.0beta

>
>
> CXXFLAGS="-Wall -O2" make
> g++ -g3 -Wall -Iinclude -O0   -c -o src/Common.o src/Common.cpp
> g++ -g3 -Wall -Iinclude -O0   -c -o src/JavaSocket.o src/JavaSocket.cpp
> g++ -g3 -Wall -Iinclude -O0   -c -o src/DriverSocket.o src/DriverSocket.cpp
> ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   https://forge.continuent.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


_______________________________________________
Carob mailing list
[email protected]
https://forge.continuent.org/mailman/listinfo/carob

Reply via email to