At a high level it looks good. I'll take a quick look at it tonight. Two comments though from a feature perspective: 1. If we do this we should revisit the message that display on the manage page. 2. This should really not happen if the services management tool isn't using CAS.
On Fri, Nov 11, 2011 at 9:28 AM, Marvin Addison <marvin.addi...@gmail.com>wrote: > > https://issues.jasig.org/browse/CAS-1067 > > I commented on the pull and on the issue. Looks good to me. Nice work, > Andrew. > > Seems like a good time to mention we need to track _all_ non-trivial > pull requests via Jira issues. If there's any doubt whether a pull is > trivial, create an issue to be safe. While code review can naturally > happen on the pull itself on the GitHub side, we need a Jira issue to > track the link to the pull and capture any important discussion so > that these changes appear in the changelog at release time. > > M > > -- > You are currently subscribed to cas-dev@lists.jasig.org as: > scott.battag...@gmail.com > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
