I understand the motivation for final classes, however none of the other AuthenticationHandler classes are final, specifically so developers may implement preAuthenticate and postAuthenticate methods from the PreAndPostProcessingAuthenticationHandler interface, so not sure why QueryDatabaseAuthenticationHandler is final.
Thanks Paul On 14 Nov 2011, at 17:21, Rhett Sutphin wrote: > Hi Paul, > > On Nov 14, 2011, at 10:57 AM, Vitty, Paul wrote: > >> Is there any reason why QueryDatabaseAuthenticationHandler >> (https://github.com/Jasig/cas/blob/master/cas-server-support-jdbc/src/main/java/org/jasig/cas/adaptors/jdbc/QueryDatabaseAuthenticationHandler.java) >> is marked as a final class? I'm trying to extend from it to implement >> below, but obviously can't as it is final. > > The motivation is documented on jasig.org[1]. I find it annoying as well, but > I can understand where the CAS developers are coming from. > > When I want to subclass a final CAS server class, I use composition instead. > If the class has a large interface, I'll use a JDK proxy to do the delegation > for unchanged methods. (I haven't looked at the particular class you're > talking about so I don't know if that makes sense for your case.) > > Rhett > > [1]: http://www.jasig.org/cas/public-api > >> >> Thanks >> Paul >> >> On 11 Nov 2011, at 17:31, Scott Battaglia wrote: >> >>> The AbstractUsernamePasswordAuthenticationHandler should extend the >>> AbstractPreAndPostProcessingAuthenticationHandler. >>> >>> >>> On Fri, Nov 11, 2011 at 12:28 PM, Vitty, Paul <p.vi...@ulster.ac.uk> wrote: >>> Hi Scott, >>> >>> I see that >>> https://github.com/Jasig/cas/blob/master/cas-server-core/src/main/java/org/jasig/cas/authentication/handler/support/AbstractPreAndPostProcessingAuthenticationHandler.java, >>> provides pre and post authenticate methods. >>> >>> https://github.com/Jasig/cas/blob/master/cas-server-support-ldap/src/main/java/org/jasig/cas/adaptors/ldap/BindLdapAuthenticationHandler.java >>> for example extends from >>> AbstractLdapUsernamePasswordAuthenticationHandler, which in turn extends >>> from AbstractUsernamePasswordAuthenticationHandler. To use the pre/post >>> hooks would require writing a completely custom new >>> BindLdapAuthenticationHandler which extends off >>> AbstractPreAndPostProcessingAuthenticationHandler? >>> >>> Thanks >>> Paul >>> >>> On 11 Nov 2011, at 17:16, Scott Battaglia wrote: >>> >>>> Most of the AuthenticationHandlers have Pre and Post hooks. Can't you >>>> just extend one and implement it pre or post? >>>> >>>> >>>> On Fri, Nov 11, 2011 at 11:53 AM, Vitty, Paul <p.vi...@ulster.ac.uk> wrote: >>>> Hi, >>>> >>>> Is there currently a feature in place to allow blacklisting of user >>>> accounts. The scenario we have in our institution is a group of users who >>>> are provisioned in our Active Directory and can currently log on to our >>>> CAS instance, but we want to prevent them from logging on. >>>> >>>> It is a requirement that they are not placed in a different OU, or have >>>> any modifications made to their AD record. They all share a similar naming >>>> convention, i.e. ^[Pp][0-9]{1, 9}$. Is there currently a method of >>>> filtering logons, regardless of the result of the authenticationHandlers? >>>> >>>> If there is not, I'd like to propose that we have some sort of pre and >>>> post authentication hooks added to AuthenticationManager interface, or >>>> even the creation of a FilteredAuthenticationManagerInterface. >>>> >>>> I have a test implementation of FilteredAuthenticationManagerImpl, which >>>> is essentially the same as AuthenticationManagerImpl, but with a pre and >>>> post filter method to define a list of filters to be applied before and >>>> after authentication attempts. If there is any interest in this, I create >>>> a JIRA issue and generate a pull request for it? >>>> >>>> Thanks >>>> Paul >>>> >>>> ________________________________ >>>> >>>> This email and any attachments are confidential and intended solely for >>>> the use of the addressee and may contain information which is covered by >>>> legal, professional or other privilege. If you have received this email in >>>> error please notify the system manager at postmas...@ulster.ac.uk and >>>> delete this email immediately. Any views or opinions expressed are solely >>>> those of the author and do not necessarily represent those of the >>>> University of Ulster. The University's computer systems may be monitored >>>> and communications carried out on them may be recorded to secure the >>>> effective operation of the system and for other lawful purposes. The >>>> University of Ulster does not guarantee that this email or any attachments >>>> are free from viruses or 100% secure. Unless expressly stated in the body >>>> of a separate attachment, the text of email is not intended to form a >>>> binding contract. Correspondence to and from the University may be subject >>>> to requests for disclosure by 3rd parties under relevant legislation. The >>>> University of Ulster was founded by Royal Charter in 1984 and is >>>> registered with company number RC000726 and VAT registered number >>>> GB672390524.The primary contact address for the University of Ulster in >>>> Northern Ireland is,Cromore Road, Coleraine, Co. Londonderry BT52 1SA >>>> >>>> -- >>>> You are currently subscribed to cas-dev@lists.jasig.org as: >>>> scott.battag...@gmail.com >>>> To unsubscribe, change settings or access archives, see >>>> http://www.ja-sig.org/wiki/display/JSG/cas-dev >>>> >>>> >>>> -- >>>> You are currently subscribed to cas-dev@lists.jasig.org as: >>>> p.vi...@ulster.ac.uk >>>> >>>> >>>> >>>> >>>> To unsubscribe, change settings or access archives, see >>>> http://www.ja-sig.org/wiki/display/JSG/cas-dev >>> >>> >>> >>> This email and any attachments are confidential and intended solely for the >>> use of the addressee and may contain information which is covered by legal, >>> professional or other privilege. If you have received this email in error >>> please notify the system manager at postmas...@ulster.ac.uk and delete this >>> email immediately. Any views or opinions expressed are solely those of the >>> author and do not necessarily represent those of the University of Ulster. >>> The University's computer systems may be monitored and communications >>> carried out on them may be recorded to secure the effective operation of >>> the system and for other lawful purposes. The University of Ulster does not >>> guarantee that this email or any attachments are free from viruses or 100% >>> secure. Unless expressly stated in the body of a separate attachment, the >>> text of email is not intended to form a binding contract. Correspondence to >>> and from the University may be subject to requests for disclosure by 3rd >>> parties under relevant legislation. The University of Ulster was founded by >>> Royal Charter in 1984 and is registered with company number RC000726 and >>> VAT registered number GB672390524.The primary contact address for the >>> University of Ulster in Northern Ireland is,Cromore Road, Coleraine, Co. >>> Londonderry BT52 1SA >>> -- >>> You are currently subscribed to cas-dev@lists.jasig.org as: >>> scott.battag...@gmail.com >>> >>> >>> To unsubscribe, change settings or access archives, see >>> http://www.ja-sig.org/wiki/display/JSG/cas-dev >>> >>> -- >>> You are currently subscribed to cas-dev@lists.jasig.org as: >>> p.vi...@ulster.ac.uk >>> To unsubscribe, change settings or access archives, see >>> http://www.ja-sig.org/wiki/display/JSG/cas-dev >> >> >> >> This email and any attachments are confidential and intended solely for the >> use of the addressee and may contain information which is covered by legal, >> professional or other privilege. If you have received this email in error >> please notify the system manager at postmas...@ulster.ac.uk and delete this >> email immediately. Any views or opinions expressed are solely those of the >> author and do not necessarily represent those of the University of Ulster. >> The University's computer systems may be monitored and communications >> carried out on them may be recorded to secure the effective operation of the >> system and for other lawful purposes. The University of Ulster does not >> guarantee that this email or any attachments are free from viruses or 100% >> secure. Unless expressly stated in the body of a separate attachment, the >> text of email is not intended to form a binding contract. Correspondence to >> and from the University may be subject to requests for disclosure by 3rd >> parties under relevant legislation. The University of Ulster was founded by >> Royal Charter in 1984 and is registered with company number RC000726 and VAT >> registered number GB672390524.The primary contact address for the University >> of Ulster in Northern Ireland is,Cromore Road, Coleraine, Co. Londonderry >> BT52 1SA >> -- >> You are currently subscribed to cas-dev@lists.jasig.org as: >> rh...@detailedbalance.net >> To unsubscribe, change settings or access archives, see >> http://www.ja-sig.org/wiki/display/JSG/cas-dev > > > -- > You are currently subscribed to cas-dev@lists.jasig.org as: > p.vi...@ulster.ac.uk > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > > ________________________________ This email and any attachments are confidential and intended solely for the use of the addressee and may contain information which is covered by legal, professional or other privilege. If you have received this email in error please notify the system manager at postmas...@ulster.ac.uk and delete this email immediately. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the University of Ulster. The University's computer systems may be monitored and communications carried out on them may be recorded to secure the effective operation of the system and for other lawful purposes. The University of Ulster does not guarantee that this email or any attachments are free from viruses or 100% secure. Unless expressly stated in the body of a separate attachment, the text of email is not intended to form a binding contract. Correspondence to and from the University may be subject to requests for disclosure by 3rd parties under relevant legislation. The University of Ulster was founded by Royal Charter in 1984 and is registered with company number RC000726 and VAT registered number GB672390524.The primary contact address for the University of Ulster in Northern Ireland is,Cromore Road, Coleraine, Co. Londonderry BT52 1SA -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
